corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1935378 - Rename popup-notifications.inc to .inc.xhtml. r=mconley

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D231229
This commit is contained in:
Tom Schuster
2024-12-06 10:47:01 +00:00
parent bde964170d
commit 790e6c028e
4 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
browser/base/content/main-popupset.inc.xhtml
View File

@@ -533,7 +533,7 @@
<description class="tooltip-label" data-l10n-id="navbar-tooltip-instruction"/> <description class="tooltip-label" data-l10n-id="navbar-tooltip-instruction"/>
</tooltip> </tooltip>
#include popup-notifications.inc #include popup-notifications.inc.xhtml
#include ../../components/customizableui/content/panelUI.inc.xhtml #include ../../components/customizableui/content/panelUI.inc.xhtml
#include ../../components/controlcenter/content/identityPanel.inc.xhtml #include ../../components/controlcenter/content/identityPanel.inc.xhtml

4
browser/base/content/popup-notifications.inc → browser/base/content/popup-notifications.inc.xhtml
View File

@@ -1,3 +1,7 @@
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
# to be included inside a popupset element # to be included inside a popupset element
<panel id="notification-popup" <panel id="notification-popup"

2
dom/docs/fedcm.rst
View File

@@ -17,7 +17,7 @@ Core spec algorithm logic and the implementation of the ``IdentityCredential`` l
The service for managing state associated with IdentityCredentials is ``IdentityCredentialStorageService`` and the service for managing the UI prompts associated with IdentityCredentials is ``IdentityCredentialPromptService``. Both definitions and implementations are in ``toolkit/components/credentialmanagement``. The service for managing state associated with IdentityCredentials is ``IdentityCredentialStorageService`` and the service for managing the UI prompts associated with IdentityCredentials is ``IdentityCredentialPromptService``. Both definitions and implementations are in ``toolkit/components/credentialmanagement``.
The UI panel is spread around a little. The actual DOM elements are in the HTML subtree with root at ``#identity-credential-notification`` in ``browser/base/content/popup-notifications.inc``. But the CSS describing it is spread through ``browser/themes/shared/customizableui/panelUI-shared.css``, ``browser/themes/shared/identity-credential-notification.css``, and ``browser/themes/shared/notification-icons.css``. Generally speaking, search for ``identity-credential`` in those files to find the relevant ids and classes. The UI panel is spread around a little. The actual DOM elements are in the HTML subtree with root at ``#identity-credential-notification`` in ``browser/base/content/popup-notifications.inc.xhtml``. But the CSS describing it is spread through ``browser/themes/shared/customizableui/panelUI-shared.css``, ``browser/themes/shared/identity-credential-notification.css``, and ``browser/themes/shared/notification-icons.css``. Generally speaking, search for ``identity-credential`` in those files to find the relevant ids and classes.
Content strings: ``browser/locales/en-US/browser/identityCredentialNotification.ftl``. Content strings: ``browser/locales/en-US/browser/identityCredentialNotification.ftl``.

2
toolkit/components/credentialmanagement/IdentityCredentialPromptService.sys.mjs
View File

@@ -127,7 +127,7 @@ export class IdentityCredentialPromptService {
// Map each identity manifest to a promise that would resolve to its icon // Map each identity manifest to a promise that would resolve to its icon
let promises = identityManifests.map(async providerManifest => { let promises = identityManifests.map(async providerManifest => {
// we don't need to set default icon because default icon is already set on popup-notifications.inc // we don't need to set default icon because default icon is already set on popup-notifications.inc.xhtml
const iconResult = await this.loadIconFromManifest(providerManifest); const iconResult = await this.loadIconFromManifest(providerManifest);
// If we didn't have a manifest with an icon, push a rejection. // If we didn't have a manifest with an icon, push a rejection.
// This will be replaced with the default icon. // This will be replaced with the default icon.