corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1412559 - Make the "confirm repost" prompt tab modal. r=bz

Browse Source 
This is done to prevent malicious pages from abusing the feature
to lock up the browser.

MozReview-Commit-ID: 8Gf55nbMwCu
This commit is contained in:
Johann Hofmann
2017-11-08 18:26:33 +01:00
parent 03ce01908c
commit 78cc8dcc4c
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
docshell/base/nsDocShell.cpp
View File

@@ -13559,6 +13559,12 @@ nsDocShell::ConfirmRepost(bool* aRepost)
return rv; return rv;
} }
// Make the repost prompt tab modal to prevent malicious pages from locking
// up the browser, see bug 1412559 for an example.
if (nsCOMPtr<nsIWritablePropertyBag2> promptBag = do_QueryInterface(prompter)) {
promptBag->SetPropertyAsBool(NS_LITERAL_STRING("allowTabModal"), true);
}
int32_t buttonPressed; int32_t buttonPressed;
// The actual value here is irrelevant, but we can't pass an invalid // The actual value here is irrelevant, but we can't pass an invalid
// bool through XPConnect. // bool through XPConnect.