corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1850293 - Make CHECKED/DEFAULT states not intrinsic. r=smaug

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D186933
This commit is contained in:
Emilio Cobos Álvarez
2023-08-30 09:18:31 +00:00
parent 3e9e56e2c8
commit 76e9b5e83c
12 changed files with 118 additions and 209 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
dom/html/nsGenericHTMLElement.cpp
View File

@@ -2035,10 +2035,8 @@ void nsGenericHTMLFormElement::UpdateFormOwner(bool aBindToTree,
MOZ_ASSERT(!aBindToTree || !aFormIdElement,
"aFormIdElement shouldn't be set if aBindToTree is true!");
bool needStateUpdate = false;
HTMLFormElement* form = GetFormInternal();
if (!aBindToTree) {
needStateUpdate = form && form->IsDefaultSubmitElement(this);
ClearForm(true, false);
form = nullptr;
}
@@ -2101,7 +2099,7 @@ void nsGenericHTMLFormElement::UpdateFormOwner(bool aBindToTree,
}
}
if (form != oldForm || needStateUpdate) {
if (form != oldForm) {
UpdateState(true);
}
}
@@ -2625,22 +2623,6 @@ void nsGenericHTMLFormControlElement::ClearForm(bool aRemoveFromForm,
nsGenericHTMLFormElement::ClearForm(aRemoveFromForm, aUnbindOrDelete);
}
ElementState nsGenericHTMLFormControlElement::IntrinsicState() const {
// If you add attribute-dependent states here, you need to add them to
// AfterSetAttr too. And add them to AfterSetAttr for all subclasses that
// implement IntrinsicState() and are affected by that attribute.
ElementState state = nsGenericHTMLFormElement::IntrinsicState();
if (mForm && mForm->IsDefaultSubmitElement(this)) {
NS_ASSERTION(IsSubmitControl(),
"Default submit element that isn't a submit control.");
// We are the default submit element (:default)
state |= ElementState::DEFAULT;
}
return state;
}
bool nsGenericHTMLFormControlElement::IsLabelable() const {
auto type = ControlType();
return (IsInputElement(type) && type != FormControlType::InputHidden) ||