Bug 1425077 - Make ModuleScript::SetErrorToRethrow call HoldJSObjects in case there is no module record r=baku

2017-12-21 16:59:12 +00:00
parent 8194cf9cc6
commit 76af191f97
1 changed files with 4 additions and 0 deletions
--- a/dom/script/ModuleScript.cpp
+++ b/dom/script/ModuleScript.cpp
@@ -102,6 +102,10 @@ ModuleScript::SetErrorToRethrow(const JS::Value& aError)
  MOZ_ASSERT(!aError.isUndefined());
  MOZ_ASSERT(!HasErrorToRethrow());

+  // This is only called after SetModuleRecord() or SetParseError() so we don't
+  // need to call HoldJSObjects() here.
+  MOZ_ASSERT(mModuleRecord || HasParseError());
+
  mErrorToRethrow = aError;
 }