Bug 1110155 - Added minimal Loop room name validation. r=mikedeboer

2014-12-19 15:22:39 +01:00
parent b696603cf3
commit 74eb03c292
5 changed files with 35 additions and 23 deletions
--- a/browser/components/loop/content/shared/js/roomStore.js
+++ b/browser/components/loop/content/shared/js/roomStore.js
@@ -423,8 +423,15 @@ loop.store = loop.store || {};
     * @param {sharedActions.RenameRoom} actionData
     */
    renameRoom: function(actionData) {
+      var newRoomName = actionData.newRoomName.trim();
+
+      // Skip update if name is unchanged or empty.
+      if (!newRoomName || this.getStoreState("roomName") === newRoomName) {
+        return;
+      }
+
      this.setStoreState({error: null});
-      this._mozLoop.rooms.rename(actionData.roomToken, actionData.newRoomName,
+      this._mozLoop.rooms.rename(actionData.roomToken, newRoomName,
        function(err) {
          if (err) {
            this.dispatchAction(new sharedActions.RenameRoomError({error: err}));