corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1920562 - Remove JS uses of Services.telemetry.setEventRecordingEnabled r=florian,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers,sfoster,nchevobbe,valentin,Gijs,dimi,lina,mconley,pdahiya,willdurand

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D223833
This commit is contained in:
Chris H-C
2024-10-08 20:14:42 +00:00
parent 2e43bfd712
commit 724b00c304
82 changed files with 6 additions and 469 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
browser/components/newtab/test/unit/lib/UTEventReporting.test.js
View File

@@ -48,7 +48,6 @@ describe("UTEventReporting", () => {
beforeEach(() => {
globals = new GlobalOverrider();
sandbox = globals.sandbox;
sandbox.stub(global.Services.telemetry, "setEventRecordingEnabled");
utEvents = new UTEventReporting();
});
@@ -84,27 +83,4 @@ describe("UTEventReporting", () => {
assert.validate(ping, UTSessionPing);
});
});
describe("#uninit()", () => {
it("should call setEventRecordingEnabled with a false value", () => {
assert.equal(
global.Services.telemetry.setEventRecordingEnabled.firstCall.args[0],
"activity_stream"
);
assert.equal(
global.Services.telemetry.setEventRecordingEnabled.firstCall.args[1],
true
);
utEvents.uninit();
assert.equal(
global.Services.telemetry.setEventRecordingEnabled.secondCall.args[0],
"activity_stream"
);
assert.equal(
global.Services.telemetry.setEventRecordingEnabled.secondCall.args[1],
false
);
});
});
});

1
browser/components/newtab/test/unit/unit-entry.js
View File

@@ -394,7 +394,6 @@ const TEST_GLOBAL = {
notifyObservers() {},
},
telemetry: {
setEventRecordingEnabled: () => {},
recordEvent: _eventDetails => {},
scalarSet: () => {},
keyedScalarAdd: () => {},

14
browser/components/newtab/test/xpcshell/test_TelemetryFeed.js
View File

@@ -1575,20 +1575,6 @@ add_task(
}
);
add_task(async function test_uninit_calls_utEvents_uninit() {
info("TelemetryFeed.uninit should call .utEvents.uninit");
let sandbox = sinon.createSandbox();
let instance = new TelemetryFeed();
sandbox.stub(instance.utEvents, "uninit");
instance.uninit();
Assert.ok(
instance.utEvents.uninit.calledOnce,
"TelemetryFeed.utEvents.uninit should be called"
);
sandbox.restore();
});
add_task(async function test_uninit_deregisters_observer() {
info(
"TelemetryFeed.uninit should make this.browserOpenNewtabStart() stop " +