corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1386600 - Change nsIStringBundle methods to return |AString| instead of |wstring|. r=emk,sr=dbaron.

Browse Source 
This removes about 2/3 of the occurrences of nsXPIDLString in the tree. The
places where nsXPIDLStrings are null-checked are replaced with |rv| checks.

The patch also removes a couple of unused declarations from
nsIStringBundle.idl.

Note that nsStringBundle::GetStringFromNameHelper() was merged into
GetStringFromName(), because they both would have had the same signature.
This commit is contained in:
Nicholas Nethercote
2017-08-04 14:40:52 +10:00
parent 3fea542b3f
commit 723f585d9c
101 changed files with 464 additions and 566 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
dom/html/HTMLFormElement.cpp
View File

@@ -919,11 +919,11 @@ HTMLFormElement::DoSecureToInsecureSubmitCheck(nsIURI* aActionURL,
nsAutoString message;
nsAutoString cont;
stringBundle->GetStringFromName(
"formPostSecureToInsecureWarning.title", getter_Copies(title));
"formPostSecureToInsecureWarning.title", title);
stringBundle->GetStringFromName(
"formPostSecureToInsecureWarning.message", getter_Copies(message));
"formPostSecureToInsecureWarning.message", message);
stringBundle->GetStringFromName(
"formPostSecureToInsecureWarning.continue", getter_Copies(cont));
"formPostSecureToInsecureWarning.continue", cont);
int32_t buttonPressed;
bool checkState = false; // this is unused (ConfirmEx requires this parameter)
rv = prompt->ConfirmEx(title.get(), message.get(),