Bug 1132747 - Set the padding for share in the context menu on Lollipop. r=mhaigh

This commit is contained in:
Michael Comella
2015-03-27 17:59:06 -07:00
parent 7d51d2992a
commit 71ca4ed285
6 changed files with 57 additions and 11 deletions

View File

@@ -90,18 +90,31 @@ public class GeckoActionProvider {
/**
* Creates the action view using the default history size.
*/
public View onCreateActionView() {
return onCreateActionView(MAX_HISTORY_SIZE_DEFAULT, false);
public View onCreateActionView(final ActionViewType viewType) {
return onCreateActionView(MAX_HISTORY_SIZE_DEFAULT, viewType);
}
public View onCreateActionView(final int maxHistorySize, final boolean isForQuickShareBar) {
public View onCreateActionView(final int maxHistorySize, final ActionViewType viewType) {
// Create the view and set its data model.
ActivityChooserModel dataModel = ActivityChooserModel.get(mContext, mHistoryFileName);
final MenuItemActionView view;
if (isForQuickShareBar) {
view = new QuickShareBarActionView(mContext, null);
} else {
view = new MenuItemActionView(mContext, null);
switch (viewType) {
case DEFAULT:
view = new MenuItemActionView(mContext, null);
break;
case QUICK_SHARE_ICON:
view = new QuickShareBarActionView(mContext, null);
break;
case CONTEXT_MENU:
view = new MenuItemActionView(mContext, null);
view.initContextMenuStyles();
break;
default:
throw new IllegalArgumentException(
"Unknown " + ActionViewType.class.getSimpleName() + ": " + viewType);
}
view.addActionButtonClickListener(mCallbacks);
@@ -251,4 +264,10 @@ public class GeckoActionProvider {
Telemetry.sendUIEvent(TelemetryContract.Event.SHARE, TelemetryContract.Method.BUTTON);
}
}
public enum ActionViewType {
DEFAULT,
QUICK_SHARE_ICON,
CONTEXT_MENU,
}
}