corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Activity

Bug 879079 - Fix rooting analysis bugs from calls to ToNumber; r=sfink

Browse Source
This commit is contained in:
Terrence Cole
2013-06-04 16:14:14 -07:00
parent 131a76981b
commit 715d757fcb
4 changed files with 18 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
js/src/jsnum.h
View File

@@ -133,23 +133,20 @@ GetPrefixInteger(JSContext *cx, const jschar *start, const jschar *end, int base
/* ES5 9.3 ToNumber, overwriting *vp with the appropriate number value. */
JS_ALWAYS_INLINE bool
ToNumber(JSContext *cx, Value *vp)
ToNumber(JSContext *cx, JS::MutableHandleValue vp)
{
#ifdef DEBUG
{
SkipRoot skip(cx, vp);
MaybeCheckStackRoots(cx);
}
MaybeCheckStackRoots(cx);
#endif
if (vp->isNumber())
if (vp.isNumber())
return true;
double d;
extern bool ToNumberSlow(JSContext *cx, js::Value v, double *dp);
if (!ToNumberSlow(cx, *vp, &d))
extern bool ToNumberSlow(JSContext *cx, Value v, double *dp);
if (!ToNumberSlow(cx, vp, &d))
return false;
vp->setNumber(d);
vp.setNumber(d);
return true;
}