Bug 1936822 - Remove unused A11Y_ flag histograms r=morgan

Differential Revision: https://phabricator.services.mozilla.com/D231948
This commit is contained in:
Chris H-C
2024-12-16 21:30:23 +00:00
parent d3571c8061
commit 7030f16e2c
7 changed files with 0 additions and 60 deletions

View File

@@ -13,28 +13,10 @@ namespace mozilla {
namespace a11y { namespace a11y {
namespace statistics { namespace statistics {
inline void A11yInitialized() {
Telemetry::Accumulate(Telemetry::A11Y_INSTANTIATED_FLAG, true);
}
inline void A11yConsumers(uint32_t aConsumer) { inline void A11yConsumers(uint32_t aConsumer) {
Telemetry::Accumulate(Telemetry::A11Y_CONSUMERS, aConsumer); Telemetry::Accumulate(Telemetry::A11Y_CONSUMERS, aConsumer);
} }
/**
* Report that ISimpleDOM* has been used.
*/
inline void ISimpleDOMUsed() {
Telemetry::Accumulate(Telemetry::A11Y_ISIMPLEDOM_USAGE_FLAG, true);
}
/**
* Report that IAccessibleTable has been used.
*/
inline void IAccessibleTableUsed() {
Telemetry::Accumulate(Telemetry::A11Y_IATABLE_USAGE_FLAG, true);
}
} // namespace statistics } // namespace statistics
} // namespace a11y } // namespace a11y
} // namespace mozilla } // namespace mozilla

View File

@@ -40,7 +40,6 @@
# include "RootAccessibleWrap.h" # include "RootAccessibleWrap.h"
#endif #endif
#include "States.h" #include "States.h"
#include "Statistics.h"
#include "TextLeafAccessible.h" #include "TextLeafAccessible.h"
#include "xpcAccessibleApplication.h" #include "xpcAccessibleApplication.h"
@@ -1592,8 +1591,6 @@ bool nsAccessibilityService::Init(uint64_t aCacheDomains) {
// domains that we activate based on information about the instantiator. // domains that we activate based on information about the instantiator.
gCacheDomains = ::GetCacheDomainsForKnownClients(aCacheDomains); gCacheDomains = ::GetCacheDomainsForKnownClients(aCacheDomains);
statistics::A11yInitialized();
static const char16_t kInitIndicator[] = {'1', 0}; static const char16_t kInitIndicator[] = {'1', 0};
observerService->NotifyObservers(nullptr, "a11y-init-or-shutdown", observerService->NotifyObservers(nullptr, "a11y-init-or-shutdown",
kInitIndicator); kInitIndicator);

View File

@@ -16,7 +16,6 @@
#include "mozilla/a11y/TableAccessible.h" #include "mozilla/a11y/TableAccessible.h"
#include "nsCOMPtr.h" #include "nsCOMPtr.h"
#include "nsString.h" #include "nsString.h"
#include "Statistics.h"
using namespace mozilla::a11y; using namespace mozilla::a11y;
@@ -34,7 +33,6 @@ ia2AccessibleTable::QueryInterface(REFIID iid, void** ppv) {
*ppv = nullptr; *ppv = nullptr;
if (IID_IAccessibleTable == iid) { if (IID_IAccessibleTable == iid) {
statistics::IAccessibleTableUsed();
*ppv = static_cast<IAccessibleTable*>(this); *ppv = static_cast<IAccessibleTable*>(this);
(reinterpret_cast<IUnknown*>(*ppv))->AddRef(); (reinterpret_cast<IUnknown*>(*ppv))->AddRef();
return S_OK; return S_OK;

View File

@@ -27,7 +27,6 @@
#include "sdnTextAccessible.h" #include "sdnTextAccessible.h"
#include "HyperTextAccessible-inl.h" #include "HyperTextAccessible-inl.h"
#include "ServiceProvider.h" #include "ServiceProvider.h"
#include "Statistics.h"
#include "ARIAMap.h" #include "ARIAMap.h"
#include "mozilla/PresShell.h" #include "mozilla/PresShell.h"
@@ -564,7 +563,6 @@ MsaaAccessible::QueryInterface(REFIID iid, void** ppv) {
*ppv = static_cast<ISimpleDOMNode*>(new sdnAccessible(WrapNotNull(this))); *ppv = static_cast<ISimpleDOMNode*>(new sdnAccessible(WrapNotNull(this)));
} else if (iid == IID_ISimpleDOMText && localAcc && localAcc->IsTextLeaf()) { } else if (iid == IID_ISimpleDOMText && localAcc && localAcc->IsTextLeaf()) {
statistics::ISimpleDOMUsed();
*ppv = static_cast<ISimpleDOMText*>(new sdnTextAccessible(this)); *ppv = static_cast<ISimpleDOMText*>(new sdnTextAccessible(this));
static_cast<IUnknown*>(*ppv)->AddRef(); static_cast<IUnknown*>(*ppv)->AddRef();
return S_OK; return S_OK;

View File

@@ -12,7 +12,6 @@
#include "nsAccessibilityService.h" #include "nsAccessibilityService.h"
#include "nsAccUtils.h" #include "nsAccUtils.h"
#include "nsWinUtils.h" #include "nsWinUtils.h"
#include "Statistics.h"
#include "sdnDocAccessible.h" #include "sdnDocAccessible.h"
#include "mozilla/a11y/Role.h" #include "mozilla/a11y/Role.h"
#include "ISimpleDOM.h" #include "ISimpleDOM.h"
@@ -54,7 +53,6 @@ MsaaDocAccessible* MsaaDocAccessible::GetFromOwned(Accessible* aAcc) {
// IUnknown // IUnknown
IMPL_IUNKNOWN_QUERY_HEAD(MsaaDocAccessible) IMPL_IUNKNOWN_QUERY_HEAD(MsaaDocAccessible)
if (aIID == IID_ISimpleDOMDocument && LocalAcc()) { if (aIID == IID_ISimpleDOMDocument && LocalAcc()) {
statistics::ISimpleDOMUsed();
*aInstancePtr = static_cast<ISimpleDOMDocument*>(new sdnDocAccessible(this)); *aInstancePtr = static_cast<ISimpleDOMDocument*>(new sdnDocAccessible(this));
static_cast<IUnknown*>(*aInstancePtr)->AddRef(); static_cast<IUnknown*>(*aInstancePtr)->AddRef();
return S_OK; return S_OK;

View File

@@ -1,14 +1,4 @@
{ {
"A11Y_INSTANTIATED_FLAG": {
"record_in_processes": ["main"],
"products": ["firefox", "fennec"],
"expires_in_version": "never",
"kind": "flag",
"releaseChannelCollection": "opt-out",
"bug_numbers": [1382820],
"description": "Flag indicating accessibility support has been instantiated.",
"alert_emails": ["accessibility@mozilla.com"]
},
"A11Y_CONSUMERS": { "A11Y_CONSUMERS": {
"record_in_processes": ["main"], "record_in_processes": ["main"],
"products": ["firefox", "fennec"], "products": ["firefox", "fennec"],
@@ -20,22 +10,6 @@
"description": "A list of known accessibility clients that inject into Firefox process space (see https://searchfox.org/mozilla-central/source/accessible/windows/msaa/Compatibility.h).", "description": "A list of known accessibility clients that inject into Firefox process space (see https://searchfox.org/mozilla-central/source/accessible/windows/msaa/Compatibility.h).",
"alert_emails": ["accessibility@mozilla.com", "jteh@mozilla.com"] "alert_emails": ["accessibility@mozilla.com", "jteh@mozilla.com"]
}, },
"A11Y_ISIMPLEDOM_USAGE_FLAG": {
"record_in_processes": ["main"],
"products": ["firefox", "fennec"],
"expires_in_version": "default",
"kind": "flag",
"description": "Flag indicating the ISimpleDOM* accessibility interfaces has been used.",
"alert_emails": ["accessibility@mozilla.com"]
},
"A11Y_IATABLE_USAGE_FLAG": {
"record_in_processes": ["main"],
"products": ["firefox", "fennec"],
"expires_in_version": "default",
"kind": "flag",
"description": "Flag indicating the IAccessibleTable accessibility interface has been used.",
"alert_emails": ["accessibility@mozilla.com"]
},
"A11Y_TREE_UPDATE_TIMING_MS": { "A11Y_TREE_UPDATE_TIMING_MS": {
"record_in_processes": ["main", "content"], "record_in_processes": ["main", "content"],
"products": ["firefox", "fennec"], "products": ["firefox", "fennec"],

View File

@@ -164,8 +164,6 @@
"XMLHTTPREQUEST_ASYNC_OR_SYNC" "XMLHTTPREQUEST_ASYNC_OR_SYNC"
], ],
"bug_numbers": [ "bug_numbers": [
"A11Y_IATABLE_USAGE_FLAG",
"A11Y_ISIMPLEDOM_USAGE_FLAG",
"APPLICATION_REPUTATION_LOCAL", "APPLICATION_REPUTATION_LOCAL",
"APPLICATION_REPUTATION_SERVER", "APPLICATION_REPUTATION_SERVER",
"APPLICATION_REPUTATION_SHOULD_BLOCK", "APPLICATION_REPUTATION_SHOULD_BLOCK",
@@ -603,18 +601,13 @@
"FX_SESSION_RESTORE_WRITE_FILE_MS", "FX_SESSION_RESTORE_WRITE_FILE_MS",
"FX_THUMBNAILS_BG_CAPTURE_PAGE_LOAD_TIME_MS", "FX_THUMBNAILS_BG_CAPTURE_PAGE_LOAD_TIME_MS",
"PLACES_BACKUPS_TOJSON_MS", "PLACES_BACKUPS_TOJSON_MS",
"A11Y_ISIMPLEDOM_USAGE_FLAG",
"FX_SESSION_RESTORE_MANUAL_RESTORE_DURATION_UNTIL_EAGER_TABS_RESTORED_MS", "FX_SESSION_RESTORE_MANUAL_RESTORE_DURATION_UNTIL_EAGER_TABS_RESTORED_MS",
"FX_SESSION_RESTORE_ALL_FILES_CORRUPT", "FX_SESSION_RESTORE_ALL_FILES_CORRUPT",
"A11Y_IATABLE_USAGE_FLAG",
"LOCALDOMSTORAGE_PRELOAD_PENDING_ON_FIRST_ACCESS", "LOCALDOMSTORAGE_PRELOAD_PENDING_ON_FIRST_ACCESS",
"PAGE_FAULTS_HARD", "PAGE_FAULTS_HARD",
"GEOLOCATION_WIN8_SOURCE_IS_MLS" "GEOLOCATION_WIN8_SOURCE_IS_MLS"
], ],
"kind": [ "kind": [
"A11Y_IATABLE_USAGE_FLAG",
"A11Y_INSTANTIATED_FLAG",
"A11Y_ISIMPLEDOM_USAGE_FLAG",
"CANVAS_WEBGL_ACCL_FAILURE_ID", "CANVAS_WEBGL_ACCL_FAILURE_ID",
"CANVAS_WEBGL_FAILURE_ID", "CANVAS_WEBGL_FAILURE_ID",
"COMPONENTS_SHIM_ACCESSED_BY_CONTENT", "COMPONENTS_SHIM_ACCESSED_BY_CONTENT",