Bug 1916093 - When generating docs, treat critical errors the same as errors. r=sylvestre,perftest-reviewers,sparky

Differential Revision: https://phabricator.services.mozilla.com/D220764

docs/config.yml

@@ -139,5 +139,6 @@ allowed_errors:
     # Bug 1915274 - General issues in nss docs.
     - "security/nss/releases/nss_3_90\\.rst.* ERROR: Content block expected for the \"container\" directive"
     - "security/nss/releases/nss_3_94\\.rst.* ERROR: Unknown target name:"
+    - "security/nss/getting_started\\.rst.* CRITICAL: Unexpected section title"
 
 max_num_warnings: 837

testing/talos/perfdocs/index.rst

@@ -377,13 +377,13 @@ Extra Talos Tests
     :local:
 
 File IO
--------
+=======
 
 File IO is tested using the tp5 test set in the `xperf`_
 test.
 
 Possible regression causes
-~~~~~~~~~~~~~~~~~~~~~~~~~~
+--------------------------
 
 -  **nonmain_startup_fileio opt (with or without e10s) windows7-32** –
    `bug
@@ -397,7 +397,7 @@ Possible regression causes
    `e10s <https://treeherder.mozilla.org/perf.html#/graphs?series=%5B%22mozilla-central%22,%222f3af3833d55ff371ecf01c41aeee1939ef3a782%22,1,1%5D&series=%5B%22try%22,%222f3af3833d55ff371ecf01c41aeee1939ef3a782%22,1,1%5D&timerange=604800>`__
 
 Xres (X Resource Monitoring)
-----------------------------
+============================
 
 A memory metric tracked during tp5 test runs. This metric is sampled
 every 20 seconds. This metric is collected on linux only.
@@ -405,7 +405,7 @@ every 20 seconds. This metric is collected on linux only.
 `xres man page <https://linux.die.net/man/3/xres>`__.
 
 % CPU
------
+=====
 
 Cpu usage tracked during tp5 test runs. This metric is sampled every 20
 seconds. This metric is collected on windows only.

tools/moztreedocs/mach_commands.py

@@ -357,7 +357,7 @@ def _check_sphinx_errors(warnings, docs_config):
     allowed_errors_regex = [re.compile(item) for item in docs_config["allowed_errors"]]
     errors = []
     for warning in warnings:
-        if "ERROR" in warning:
+        if warning in ["ERROR", "CRITICAL"]:
             if not (any(item.search(warning) for item in allowed_errors_regex)):
                 errors.append(warning)
     return errors