corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1490044 - Move all prefs used in WebIDL to StaticPrefs. r=bzbarsky

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D33507
This commit is contained in:
Peter Van der Beken
2019-06-13 09:00:59 +00:00
parent e71934492d
commit 6c1f25a923
48 changed files with 701 additions and 459 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
dom/html/HTMLInputElement.cpp
View File

@@ -448,7 +448,7 @@ void GetDOMFileOrDirectoryPath(const OwningFileOrDirectory& aData,
/* static */
bool HTMLInputElement::ValueAsDateEnabled(JSContext* cx, JSObject* obj) {
return IsExperimentalFormsEnabled() || IsInputDateTimeEnabled() ||
return IsExperimentalFormsEnabled() || StaticPrefs::dom_forms_datetime() ||
IsInputDateTimeOthersEnabled();
}
@@ -1918,7 +1918,7 @@ nsresult HTMLInputElement::ApplyStep(int32_t aStep) {
/* static */
bool HTMLInputElement::IsExperimentalMobileType(uint8_t aType) {
return (aType == NS_FORM_INPUT_DATE || aType == NS_FORM_INPUT_TIME) &&
!IsInputDateTimeEnabled();
!StaticPrefs::dom_forms_datetime();
}
bool HTMLInputElement::IsDateTimeInputType(uint8_t aType) {
@@ -2336,7 +2336,7 @@ void HTMLInputElement::GetDisplayFileName(nsAString& aValue) const {
nsAutoString value;
if (mFileData->mFilesOrDirectories.IsEmpty()) {
if ((IsDirPickerEnabled() && Allowdirs()) ||
if ((StaticPrefs::dom_input_dirpicker() && Allowdirs()) ||
(StaticPrefs::dom_webkitBlink_dirPicker_enabled() &&
HasAttr(kNameSpaceID_None, nsGkAtoms::webkitdirectory))) {
nsContentUtils::GetLocalizedString(nsContentUtils::eFORMS_PROPERTIES,
@@ -2375,7 +2375,7 @@ void HTMLInputElement::SetFilesOrDirectories(
mFileData->ClearGetFilesHelpers();
if (IsWebkitFileSystemEnabled()) {
if (StaticPrefs::dom_webkitBlink_filesystem_enabled()) {
HTMLInputElement_Binding::ClearCachedWebkitEntriesValue(this);
mFileData->mEntries.Clear();
}
@@ -2392,7 +2392,7 @@ void HTMLInputElement::SetFiles(FileList* aFiles, bool aSetValueChanged) {
mFileData->mFilesOrDirectories.Clear();
mFileData->ClearGetFilesHelpers();
if (IsWebkitFileSystemEnabled()) {
if (StaticPrefs::dom_webkitBlink_filesystem_enabled()) {
HTMLInputElement_Binding::ClearCachedWebkitEntriesValue(this);
mFileData->mEntries.Clear();
}
@@ -2418,7 +2418,7 @@ void HTMLInputElement::MozSetDndFilesAndDirectories(
SetFilesOrDirectories(aFilesOrDirectories, true);
if (IsWebkitFileSystemEnabled()) {
if (StaticPrefs::dom_webkitBlink_filesystem_enabled()) {
UpdateEntries(aFilesOrDirectories);
}
@@ -2499,7 +2499,7 @@ FileList* HTMLInputElement::GetFiles() {
return nullptr;
}
if (IsDirPickerEnabled() && Allowdirs() &&
if (StaticPrefs::dom_input_dirpicker() && Allowdirs() &&
(!StaticPrefs::dom_webkitBlink_dirPicker_enabled() ||
!HasAttr(kNameSpaceID_None, nsGkAtoms::webkitdirectory))) {
return nullptr;
@@ -3647,7 +3647,7 @@ nsresult HTMLInputElement::MaybeInitPickers(EventChainPostVisitor& aVisitor) {
nsCOMPtr<nsIContent> target =
do_QueryInterface(aVisitor.mEvent->mOriginalTarget);
if (target && target->FindFirstNonChromeOnlyAccessContent() == this &&
((IsDirPickerEnabled() && Allowdirs()) ||
((StaticPrefs::dom_input_dirpicker() && Allowdirs()) ||
(StaticPrefs::dom_webkitBlink_dirPicker_enabled() &&
HasAttr(kNameSpaceID_None, nsGkAtoms::webkitdirectory)))) {
type = FILE_PICKER_DIRECTORY;
@@ -5108,39 +5108,14 @@ bool HTMLInputElement::ParseTime(const nsAString& aValue, uint32_t* aResult) {
bool HTMLInputElement::IsDateTimeTypeSupported(uint8_t aDateTimeInputType) {
return ((aDateTimeInputType == NS_FORM_INPUT_DATE ||
aDateTimeInputType == NS_FORM_INPUT_TIME) &&
(IsInputDateTimeEnabled() || IsExperimentalFormsEnabled())) ||
(StaticPrefs::dom_forms_datetime() ||
IsExperimentalFormsEnabled())) ||
((aDateTimeInputType == NS_FORM_INPUT_MONTH ||
aDateTimeInputType == NS_FORM_INPUT_WEEK ||
aDateTimeInputType == NS_FORM_INPUT_DATETIME_LOCAL) &&
IsInputDateTimeOthersEnabled());
}
/* static */
bool HTMLInputElement::IsWebkitFileSystemEnabled() {
static bool sWebkitFileSystemEnabled = false;
static bool sWebkitFileSystemPrefCached = false;
if (!sWebkitFileSystemPrefCached) {
sWebkitFileSystemPrefCached = true;
Preferences::AddBoolVarCache(&sWebkitFileSystemEnabled,
"dom.webkitBlink.filesystem.enabled", false);
}
return sWebkitFileSystemEnabled;
}
/* static */
bool HTMLInputElement::IsDirPickerEnabled() {
static bool sDirPickerEnabled = false;
static bool sDirPickerPrefCached = false;
if (!sDirPickerPrefCached) {
sDirPickerPrefCached = true;
Preferences::AddBoolVarCache(&sDirPickerEnabled, "dom.input.dirpicker",
false);
}
return sDirPickerEnabled;
}
/* static */
bool HTMLInputElement::IsExperimentalFormsEnabled() {
static bool sExperimentalFormsEnabled = false;
@@ -5154,19 +5129,6 @@ bool HTMLInputElement::IsExperimentalFormsEnabled() {
return sExperimentalFormsEnabled;
}
/* static */
bool HTMLInputElement::IsInputDateTimeEnabled() {
static bool sDateTimeEnabled = false;
static bool sDateTimePrefCached = false;
if (!sDateTimePrefCached) {
sDateTimePrefCached = true;
Preferences::AddBoolVarCache(&sDateTimeEnabled, "dom.forms.datetime",
false);
}
return sDateTimeEnabled;
}
/* static */
bool HTMLInputElement::IsInputDateTimeOthersEnabled() {
static bool sDateTimeOthersEnabled = false;