corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bug 1212906 - don't handle windows messages while waiting for a sync a11y ipc message r=billm

Browse Source 
Windows messages can trigger sync ipc messages to the child process.  That
means if we handle windows messages while waiting for the response to a sync
a11y ipc message we can end up reentering the code to send ipc messages which
is bad.  Try and avoid this situation by not handling windows messages while
waiting for a sync a11y message.
This commit is contained in:
Trevor Saunders
2015-10-07 17:38:08 -04:00
parent 5ec8f09e4d
commit 68d7493cd0
6 changed files with 33 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ipc/glue/WindowsMessageLoop.cpp
View File

@@ -944,7 +944,7 @@ DeneuteredWindowRegion::~DeneuteredWindowRegion()
}
bool
MessageChannel::WaitForSyncNotify()
MessageChannel::WaitForSyncNotify(bool aHandleWindowsMessages)
{
mMonitor->AssertCurrentThreadOwns();
@@ -952,7 +952,7 @@ MessageChannel::WaitForSyncNotify()
// Use a blocking wait if this channel does not require
// Windows message deferral behavior.
if (!(mFlags & REQUIRE_DEFERRED_MESSAGE_PROTECTION)) {
if (!(mFlags & REQUIRE_DEFERRED_MESSAGE_PROTECTION) || !aHandleWindowsMessages) {
PRIntervalTime timeout = (kNoTimeout == mTimeoutMs) ?
PR_INTERVAL_NO_TIMEOUT :
PR_MillisecondsToInterval(mTimeoutMs);
@@ -1088,7 +1088,7 @@ MessageChannel::WaitForInterruptNotify()
// Re-use sync notification wait code if this channel does not require
// Windows message deferral behavior.
if (!(mFlags & REQUIRE_DEFERRED_MESSAGE_PROTECTION)) {
return WaitForSyncNotify();
return WaitForSyncNotify(true);
}
if (!InterruptStackDepth() && !AwaitingIncomingMessage()) {