corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1428535 - Add missing override specifiers to overridden virtual functions. r=froydnj

Browse Source 
MozReview-Commit-ID: DCPTnyBooIe
This commit is contained in:
Chris Peterson
2017-11-05 19:37:28 -08:00
parent ab8be1cee1
commit 677bf4030c
433 changed files with 3797 additions and 3674 deletions
Download Patch File Download Diff File Expand all files Collapse all files

95
js/ipc/JavaScriptBase.h
View File

@@ -24,13 +24,13 @@ class JavaScriptBase : public WrapperOwner, public WrapperAnswer, public Base
public:
virtual ~JavaScriptBase() {}
virtual void ActorDestroy(WrapperOwner::ActorDestroyReason why) {
virtual void ActorDestroy(WrapperOwner::ActorDestroyReason why) override {
WrapperOwner::ActorDestroy(why);
}
/*** IPC handlers ***/
mozilla::ipc::IPCResult RecvPreventExtensions(const uint64_t& objId, ReturnStatus* rs) {
mozilla::ipc::IPCResult RecvPreventExtensions(const uint64_t& objId, ReturnStatus* rs) override {
if (!Answer::RecvPreventExtensions(ObjectId::deserialize(objId), rs)) {
return IPC_FAIL_NO_REASON(this);
}
@@ -38,7 +38,7 @@ class JavaScriptBase : public WrapperOwner, public WrapperAnswer, public Base
}
mozilla::ipc::IPCResult RecvGetPropertyDescriptor(const uint64_t& objId, const JSIDVariant& id,
ReturnStatus* rs,
PPropertyDescriptor* out) {
PPropertyDescriptor* out) override {
if (!Answer::RecvGetPropertyDescriptor(ObjectId::deserialize(objId), id, rs, out)) {
return IPC_FAIL_NO_REASON(this);
}
@@ -47,21 +47,21 @@ class JavaScriptBase : public WrapperOwner, public WrapperAnswer, public Base
mozilla::ipc::IPCResult RecvGetOwnPropertyDescriptor(const uint64_t& objId,
const JSIDVariant& id,
ReturnStatus* rs,
PPropertyDescriptor* out) {
PPropertyDescriptor* out) override {
if (!Answer::RecvGetOwnPropertyDescriptor(ObjectId::deserialize(objId), id, rs, out)) {
return IPC_FAIL_NO_REASON(this);
}
return IPC_OK();
}
mozilla::ipc::IPCResult RecvDefineProperty(const uint64_t& objId, const JSIDVariant& id,
const PPropertyDescriptor& flags, ReturnStatus* rs) {
const PPropertyDescriptor& flags, ReturnStatus* rs) override {
if (!Answer::RecvDefineProperty(ObjectId::deserialize(objId), id, flags, rs)) {
return IPC_FAIL_NO_REASON(this);
}
return IPC_OK();
}
mozilla::ipc::IPCResult RecvDelete(const uint64_t& objId, const JSIDVariant& id,
ReturnStatus* rs) {
ReturnStatus* rs) override {
if (!Answer::RecvDelete(ObjectId::deserialize(objId), id, rs)) {
return IPC_FAIL_NO_REASON(this);
}
@@ -69,28 +69,28 @@ class JavaScriptBase : public WrapperOwner, public WrapperAnswer, public Base
}
mozilla::ipc::IPCResult RecvHas(const uint64_t& objId, const JSIDVariant& id,
ReturnStatus* rs, bool* bp) {
ReturnStatus* rs, bool* bp) override {
if (!Answer::RecvHas(ObjectId::deserialize(objId), id, rs, bp)) {
return IPC_FAIL_NO_REASON(this);
}
return IPC_OK();
}
mozilla::ipc::IPCResult RecvHasOwn(const uint64_t& objId, const JSIDVariant& id,
ReturnStatus* rs, bool* bp) {
ReturnStatus* rs, bool* bp) override {
if (!Answer::RecvHasOwn(ObjectId::deserialize(objId), id, rs, bp)) {
return IPC_FAIL_NO_REASON(this);
}
return IPC_OK();
}
mozilla::ipc::IPCResult RecvGet(const uint64_t& objId, const JSVariant& receiverVar, const JSIDVariant& id,
ReturnStatus* rs, JSVariant* result) {
ReturnStatus* rs, JSVariant* result) override {
if (!Answer::RecvGet(ObjectId::deserialize(objId), receiverVar, id, rs, result)) {
return IPC_FAIL_NO_REASON(this);
}
return IPC_OK();
}
mozilla::ipc::IPCResult RecvSet(const uint64_t& objId, const JSIDVariant& id, const JSVariant& value,
const JSVariant& receiverVar, ReturnStatus* rs) {
const JSVariant& receiverVar, ReturnStatus* rs) override {
if (!Answer::RecvSet(ObjectId::deserialize(objId), id, value, receiverVar, rs)) {
return IPC_FAIL_NO_REASON(this);
}
@@ -98,7 +98,7 @@ class JavaScriptBase : public WrapperOwner, public WrapperAnswer, public Base
}
mozilla::ipc::IPCResult RecvIsExtensible(const uint64_t& objId, ReturnStatus* rs,
bool* result) {
bool* result) override {
if (!Answer::RecvIsExtensible(ObjectId::deserialize(objId), rs, result)) {
return IPC_FAIL_NO_REASON(this);
}
@@ -106,51 +106,51 @@ class JavaScriptBase : public WrapperOwner, public WrapperAnswer, public Base
}
mozilla::ipc::IPCResult RecvCallOrConstruct(const uint64_t& objId, InfallibleTArray<JSParam>&& argv,
const bool& construct, ReturnStatus* rs, JSVariant* result,
nsTArray<JSParam>* outparams) {
nsTArray<JSParam>* outparams) override {
if (!Answer::RecvCallOrConstruct(ObjectId::deserialize(objId), Move(argv), construct, rs, result, outparams)) {
return IPC_FAIL_NO_REASON(this);
}
return IPC_OK();
}
mozilla::ipc::IPCResult RecvHasInstance(const uint64_t& objId, const JSVariant& v, ReturnStatus* rs, bool* bp) {
mozilla::ipc::IPCResult RecvHasInstance(const uint64_t& objId, const JSVariant& v, ReturnStatus* rs, bool* bp) override {
if (!Answer::RecvHasInstance(ObjectId::deserialize(objId), v, rs, bp)) {
return IPC_FAIL_NO_REASON(this);
}
return IPC_OK();
}
mozilla::ipc::IPCResult RecvGetBuiltinClass(const uint64_t& objId, ReturnStatus* rs, uint32_t* classValue) {
mozilla::ipc::IPCResult RecvGetBuiltinClass(const uint64_t& objId, ReturnStatus* rs, uint32_t* classValue) override {
if (!Answer::RecvGetBuiltinClass(ObjectId::deserialize(objId), rs, classValue)) {
return IPC_FAIL_NO_REASON(this);
}
return IPC_OK();
}
mozilla::ipc::IPCResult RecvIsArray(const uint64_t& objId, ReturnStatus* rs, uint32_t* answer) {
mozilla::ipc::IPCResult RecvIsArray(const uint64_t& objId, ReturnStatus* rs, uint32_t* answer) override {
if (!Answer::RecvIsArray(ObjectId::deserialize(objId), rs, answer)) {
return IPC_FAIL_NO_REASON(this);
}
return IPC_OK();
}
mozilla::ipc::IPCResult RecvClassName(const uint64_t& objId, nsCString* result) {
mozilla::ipc::IPCResult RecvClassName(const uint64_t& objId, nsCString* result) override {
if (!Answer::RecvClassName(ObjectId::deserialize(objId), result)) {
return IPC_FAIL_NO_REASON(this);
}
return IPC_OK();
}
mozilla::ipc::IPCResult RecvGetPrototype(const uint64_t& objId, ReturnStatus* rs, ObjectOrNullVariant* result) {
mozilla::ipc::IPCResult RecvGetPrototype(const uint64_t& objId, ReturnStatus* rs, ObjectOrNullVariant* result) override {
if (!Answer::RecvGetPrototype(ObjectId::deserialize(objId), rs, result)) {
return IPC_FAIL_NO_REASON(this);
}
return IPC_OK();
}
mozilla::ipc::IPCResult RecvGetPrototypeIfOrdinary(const uint64_t& objId, ReturnStatus* rs, bool* isOrdinary,
ObjectOrNullVariant* result)
ObjectOrNullVariant* result) override
{
if (!Answer::RecvGetPrototypeIfOrdinary(ObjectId::deserialize(objId), rs, isOrdinary, result)) {
return IPC_FAIL_NO_REASON(this);
}
return IPC_OK();
}
mozilla::ipc::IPCResult RecvRegExpToShared(const uint64_t& objId, ReturnStatus* rs, nsString* source, uint32_t* flags) {
mozilla::ipc::IPCResult RecvRegExpToShared(const uint64_t& objId, ReturnStatus* rs, nsString* source, uint32_t* flags) override {
if (!Answer::RecvRegExpToShared(ObjectId::deserialize(objId), rs, source, flags)) {
return IPC_FAIL_NO_REASON(this);
}
@@ -158,28 +158,28 @@ class JavaScriptBase : public WrapperOwner, public WrapperAnswer, public Base
}
mozilla::ipc::IPCResult RecvGetPropertyKeys(const uint64_t& objId, const uint32_t& flags,
ReturnStatus* rs, nsTArray<JSIDVariant>* ids) {
ReturnStatus* rs, nsTArray<JSIDVariant>* ids) override {
if (!Answer::RecvGetPropertyKeys(ObjectId::deserialize(objId), flags, rs, ids)) {
return IPC_FAIL_NO_REASON(this);
}
return IPC_OK();
}
mozilla::ipc::IPCResult RecvInstanceOf(const uint64_t& objId, const JSIID& iid,
ReturnStatus* rs, bool* instanceof) {
ReturnStatus* rs, bool* instanceof) override {
if (!Answer::RecvInstanceOf(ObjectId::deserialize(objId), iid, rs, instanceof)) {
return IPC_FAIL_NO_REASON(this);
}
return IPC_OK();
}
mozilla::ipc::IPCResult RecvDOMInstanceOf(const uint64_t& objId, const int& prototypeID, const int& depth,
ReturnStatus* rs, bool* instanceof) {
ReturnStatus* rs, bool* instanceof) override {
if (!Answer::RecvDOMInstanceOf(ObjectId::deserialize(objId), prototypeID, depth, rs, instanceof)) {
return IPC_FAIL_NO_REASON(this);
}
return IPC_OK();
}
mozilla::ipc::IPCResult RecvDropObject(const uint64_t& objId) {
mozilla::ipc::IPCResult RecvDropObject(const uint64_t& objId) override {
if (!Answer::RecvDropObject(ObjectId::deserialize(objId))) {
return IPC_FAIL_NO_REASON(this);
}
@@ -188,104 +188,103 @@ class JavaScriptBase : public WrapperOwner, public WrapperAnswer, public Base
/*** Dummy call handlers ***/
bool SendDropObject(const ObjectId& objId) {
bool SendDropObject(const ObjectId& objId) override {
return Base::SendDropObject(objId.serialize());
}
bool SendPreventExtensions(const ObjectId& objId, ReturnStatus* rs) {
bool SendPreventExtensions(const ObjectId& objId, ReturnStatus* rs) override {
return Base::SendPreventExtensions(objId.serialize(), rs);
}
bool SendGetPropertyDescriptor(const ObjectId& objId, const JSIDVariant& id,
ReturnStatus* rs,
PPropertyDescriptor* out) {
PPropertyDescriptor* out) override {
return Base::SendGetPropertyDescriptor(objId.serialize(), id, rs, out);
}
bool SendGetOwnPropertyDescriptor(const ObjectId& objId,
const JSIDVariant& id,
ReturnStatus* rs,
PPropertyDescriptor* out) {
PPropertyDescriptor* out) override {
return Base::SendGetOwnPropertyDescriptor(objId.serialize(), id, rs, out);
}
bool SendDefineProperty(const ObjectId& objId, const JSIDVariant& id,
const PPropertyDescriptor& flags,
ReturnStatus* rs) {
ReturnStatus* rs) override {
return Base::SendDefineProperty(objId.serialize(), id, flags, rs);
}
bool SendDelete(const ObjectId& objId, const JSIDVariant& id, ReturnStatus* rs) {
bool SendDelete(const ObjectId& objId, const JSIDVariant& id, ReturnStatus* rs) override {
return Base::SendDelete(objId.serialize(), id, rs);
}
bool SendHas(const ObjectId& objId, const JSIDVariant& id,
ReturnStatus* rs, bool* bp) {
ReturnStatus* rs, bool* bp) override {
return Base::SendHas(objId.serialize(), id, rs, bp);
}
bool SendHasOwn(const ObjectId& objId, const JSIDVariant& id,
ReturnStatus* rs, bool* bp) {
ReturnStatus* rs, bool* bp) override {
return Base::SendHasOwn(objId.serialize(), id, rs, bp);
}
bool SendGet(const ObjectId& objId, const JSVariant& receiverVar, const JSIDVariant& id,
ReturnStatus* rs, JSVariant* result) {
ReturnStatus* rs, JSVariant* result) override {
return Base::SendGet(objId.serialize(), receiverVar, id, rs, result);
}
bool SendSet(const ObjectId& objId, const JSIDVariant& id, const JSVariant& value,
const JSVariant& receiverVar, ReturnStatus* rs) {
const JSVariant& receiverVar, ReturnStatus* rs) override {
return Base::SendSet(objId.serialize(), id, value, receiverVar, rs);
}
bool SendIsExtensible(const ObjectId& objId, ReturnStatus* rs,
bool* result) {
bool SendIsExtensible(const ObjectId& objId, ReturnStatus* rs, bool* result) override {
return Base::SendIsExtensible(objId.serialize(), rs, result);
}
bool SendCallOrConstruct(const ObjectId& objId, const nsTArray<JSParam>& argv,
const bool& construct, ReturnStatus* rs, JSVariant* result,
nsTArray<JSParam>* outparams) {
nsTArray<JSParam>* outparams) override {
return Base::SendCallOrConstruct(objId.serialize(), argv, construct, rs, result, outparams);
}
bool SendHasInstance(const ObjectId& objId, const JSVariant& v, ReturnStatus* rs, bool* bp) {
bool SendHasInstance(const ObjectId& objId, const JSVariant& v, ReturnStatus* rs, bool* bp) override {
return Base::SendHasInstance(objId.serialize(), v, rs, bp);
}
bool SendGetBuiltinClass(const ObjectId& objId, ReturnStatus* rs, uint32_t* classValue) {
bool SendGetBuiltinClass(const ObjectId& objId, ReturnStatus* rs, uint32_t* classValue) override {
return Base::SendGetBuiltinClass(objId.serialize(), rs, classValue);
}
bool SendIsArray(const ObjectId& objId, ReturnStatus* rs, uint32_t* answer)
bool SendIsArray(const ObjectId& objId, ReturnStatus* rs, uint32_t* answer) override
{
return Base::SendIsArray(objId.serialize(), rs, answer);
}
bool SendClassName(const ObjectId& objId, nsCString* result) {
bool SendClassName(const ObjectId& objId, nsCString* result) override {
return Base::SendClassName(objId.serialize(), result);
}
bool SendGetPrototype(const ObjectId& objId, ReturnStatus* rs, ObjectOrNullVariant* result) {
bool SendGetPrototype(const ObjectId& objId, ReturnStatus* rs, ObjectOrNullVariant* result) override {
return Base::SendGetPrototype(objId.serialize(), rs, result);
}
bool SendGetPrototypeIfOrdinary(const ObjectId& objId, ReturnStatus* rs, bool* isOrdinary,
ObjectOrNullVariant* result)
ObjectOrNullVariant* result) override
{
return Base::SendGetPrototypeIfOrdinary(objId.serialize(), rs, isOrdinary, result);
}
bool SendRegExpToShared(const ObjectId& objId, ReturnStatus* rs,
nsString* source, uint32_t* flags) {
nsString* source, uint32_t* flags) override {
return Base::SendRegExpToShared(objId.serialize(), rs, source, flags);
}
bool SendGetPropertyKeys(const ObjectId& objId, const uint32_t& flags,
ReturnStatus* rs, nsTArray<JSIDVariant>* ids) {
ReturnStatus* rs, nsTArray<JSIDVariant>* ids) override {
return Base::SendGetPropertyKeys(objId.serialize(), flags, rs, ids);
}
bool SendInstanceOf(const ObjectId& objId, const JSIID& iid,
ReturnStatus* rs, bool* instanceof) {
ReturnStatus* rs, bool* instanceof) override {
return Base::SendInstanceOf(objId.serialize(), iid, rs, instanceof);
}
bool SendDOMInstanceOf(const ObjectId& objId, const int& prototypeID, const int& depth,
ReturnStatus* rs, bool* instanceof) {
ReturnStatus* rs, bool* instanceof) override {
return Base::SendDOMInstanceOf(objId.serialize(), prototypeID, depth, rs, instanceof);
}
/* The following code is needed to suppress a bogus MSVC warning (C4250). */
virtual bool toObjectVariant(JSContext* cx, JSObject* obj, ObjectVariant* objVarp) {
virtual bool toObjectVariant(JSContext* cx, JSObject* obj, ObjectVariant* objVarp) override {
return WrapperOwner::toObjectVariant(cx, obj, objVarp);
}
virtual JSObject* fromObjectVariant(JSContext* cx, const ObjectVariant& objVar) {
virtual JSObject* fromObjectVariant(JSContext* cx, const ObjectVariant& objVar) override {
return WrapperOwner::fromObjectVariant(cx, objVar);
}
};