corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1856374 - Add a pref to stop forcing details elements to be blocks. r=TYLin

Browse Source 
This is probably something we want to move towards, so it doesn't hurt
adding a pref to allow people to experiment with it.

Differential Revision: https://phabricator.services.mozilla.com/D189919
This commit is contained in:
Emilio Cobos Álvarez
2023-10-05 16:59:33 +00:00
parent c8a1abb684
commit 67372ce7e5
7 changed files with 51 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
layout/base/nsCSSFrameConstructor.cpp
View File

@@ -3239,18 +3239,17 @@ nsIFrame* nsCSSFrameConstructor::ConstructFieldSetFrame(
return fieldsetFrame;
}
nsIFrame* nsCSSFrameConstructor::ConstructDetails(
nsFrameConstructorState& aState, FrameConstructionItem& aItem,
nsContainerFrame* aParentFrame, const nsStyleDisplay* aStyleDisplay,
nsFrameList& aFrameList) {
if (!aStyleDisplay->IsScrollableOverflow()) {
return ConstructNonScrollableBlock(aState, aItem, aParentFrame,
aStyleDisplay, aFrameList);
const nsCSSFrameConstructor::FrameConstructionData*
nsCSSFrameConstructor::FindDetailsData(const Element& aElement,
ComputedStyle& aStyle) {
if (!StaticPrefs::layout_details_force_block_layout()) {
return nullptr;
}
// Build a scroll frame if necessary.
return ConstructScrollableBlock(aState, aItem, aParentFrame, aStyleDisplay,
aFrameList);
static constexpr FrameConstructionData sBlockData[2] = {
{&nsCSSFrameConstructor::ConstructNonScrollableBlock},
{&nsCSSFrameConstructor::ConstructScrollableBlock},
};
return &sBlockData[aStyle.StyleDisplay()->IsScrollableOverflow()];
}
nsIFrame* nsCSSFrameConstructor::ConstructBlockRubyFrame(
@@ -3496,7 +3495,8 @@ nsCSSFrameConstructor::FindHTMLData(const Element& aElement,
SIMPLE_TAG_CREATE(audio, NS_NewHTMLVideoFrame),
SIMPLE_TAG_CREATE(progress, NS_NewProgressFrame),
SIMPLE_TAG_CREATE(meter, NS_NewMeterFrame),
COMPLEX_TAG_CREATE(details, &nsCSSFrameConstructor::ConstructDetails)};
SIMPLE_TAG_CHAIN(details, nsCSSFrameConstructor::FindDetailsData),
};
return FindDataByTag(aElement, aStyle, sHTMLData, ArrayLength(sHTMLData));
}