corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 901976 - don't null-check |new X| in xpcom/; r=bsmedberg

Browse Source
This commit is contained in:
Nathan Froyd
2013-08-05 11:16:53 -04:00
parent d3227fe9b3
commit 66b65565bd
9 changed files with 33 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
xpcom/base/nsErrorService.cpp
View File

@@ -5,6 +5,7 @@
#include "nsErrorService.h"
#include "nsCRT.h"
#include "nsAutoPtr.h"
static void*
CloneCString(nsHashKey *aKey, void *aData, void* closure)
@@ -65,13 +66,8 @@ nsresult
nsErrorService::Create(nsISupports* outer, const nsIID& aIID, void* *aInstancePtr)
{
NS_ENSURE_NO_AGGREGATION(outer);
nsErrorService* serv = new nsErrorService();
if (serv == nullptr)
return NS_ERROR_OUT_OF_MEMORY;
NS_ADDREF(serv);
nsresult rv = serv->QueryInterface(aIID, aInstancePtr);
NS_RELEASE(serv);
return rv;
nsRefPtr<nsErrorService> serv = new nsErrorService();
return serv->QueryInterface(aIID, aInstancePtr);
}
NS_IMETHODIMP