Bug 1452080: Remove ComputedStyle::PresContext usage from layout and canvas code. r=xidorn

Couldn't find an easy way of splitting these up :(

MozReview-Commit-ID: 2kTZ5McREUT
This commit is contained in:
Emilio Cobos Álvarez
2018-04-06 14:52:12 +02:00
parent 19d1b6d206
commit 65978b31f3
20 changed files with 154 additions and 92 deletions

View File

@@ -2850,6 +2850,7 @@ GetNormalLineHeight(nsFontMetrics* aFontMetrics)
static inline nscoord
ComputeLineHeight(ComputedStyle* aComputedStyle,
nsPresContext* aPresContext,
nscoord aBlockBSize,
float aFontSizeInflation)
{
@@ -2883,7 +2884,7 @@ ComputeLineHeight(ComputedStyle* aComputedStyle,
}
RefPtr<nsFontMetrics> fm = nsLayoutUtils::
GetFontMetricsForComputedStyle(aComputedStyle, aFontSizeInflation);
GetFontMetricsForComputedStyle(aComputedStyle, aPresContext, aFontSizeInflation);
return GetNormalLineHeight(fm);
}
@@ -2894,20 +2895,27 @@ ReflowInput::CalcLineHeight() const
nsLayoutUtils::IsNonWrapperBlock(mFrame) ? ComputedBSize() :
(mCBReflowInput ? mCBReflowInput->ComputedBSize() : NS_AUTOHEIGHT);
return CalcLineHeight(mFrame->GetContent(), mFrame->Style(), blockBSize,
return CalcLineHeight(mFrame->GetContent(),
mFrame->Style(),
mFrame->PresContext(),
blockBSize,
nsLayoutUtils::FontSizeInflationFor(mFrame));
}
/* static */ nscoord
ReflowInput::CalcLineHeight(nsIContent* aContent,
ComputedStyle* aComputedStyle,
nscoord aBlockBSize,
float aFontSizeInflation)
ComputedStyle* aComputedStyle,
nsPresContext* aPresContext,
nscoord aBlockBSize,
float aFontSizeInflation)
{
NS_PRECONDITION(aComputedStyle, "Must have a ComputedStyle");
nscoord lineHeight =
ComputeLineHeight(aComputedStyle, aBlockBSize, aFontSizeInflation);
ComputeLineHeight(aComputedStyle,
aPresContext,
aBlockBSize,
aFontSizeInflation);
NS_ASSERTION(lineHeight >= 0, "ComputeLineHeight screwed up");