corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

b=576067; Let WebGL use CheckedInt; r=vladimir

Browse Source
This commit is contained in:
Benoit Jacob
2010-07-03 18:32:19 -04:00
parent da94c1cf46
commit 62eb94f239
6 changed files with 178 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
content/canvas/src/WebGLContextValidate.cpp
View File

@@ -39,6 +39,8 @@
#include "WebGLContext.h"
#include "CheckedInt.h"
using namespace mozilla;
/*
@@ -112,12 +114,18 @@ WebGLContext::ValidateBuffers(PRUint32 count)
continue;
// compute the number of bytes we actually need
WebGLuint needed = vd.byteOffset + // the base offset
vd.actualStride() * (count-1) + // to stride to the start of the last element group
vd.componentSize() * vd.size; // and the number of bytes needed for these components
CheckedUint32 checked_needed = CheckedUint32(vd.byteOffset) + // the base offset
CheckedUint32(vd.actualStride()) * (count-1) + // to stride to the start of the last element group
CheckedUint32(vd.componentSize()) * vd.size; // and the number of bytes needed for these components
if (vd.buf->ByteLength() < needed) {
LogMessage("VBO too small for bound attrib index %d: need at least %d bytes, but have only %d", i, needed, vd.buf->ByteLength());
if (!checked_needed.valid()) {
LogMessage("Integer overflow computing the size of bound vertex attrib buffer at index %d", i);
return PR_FALSE;
}
if (vd.buf->ByteLength() < checked_needed.value()) {
LogMessage("VBO too small for bound attrib index %d: need at least %d bytes, but have only %d",
i, checked_needed.value(), vd.buf->ByteLength());
return PR_FALSE;
}
}