Bug 1937545 - Remove inline event handlers from RecentlyClosedTabsAndWindowsMenuUtils r=sessionstore-reviewers,dao

Differential Revision: https://phabricator.services.mozilla.com/D232618
This commit is contained in:
Tom Schuster
2024-12-19 14:01:10 +00:00
parent 24da03adfb
commit 60946c123d

View File

@@ -439,13 +439,14 @@ function createEntry(
}
if (aIsWindowsFragment) {
element.setAttribute("oncommand", `undoCloseWindow("${aIndex}");`);
element.addEventListener("command", event =>
event.target.ownerGlobal.undoCloseWindow(aIndex)
);
} else if (typeof aClosedTab.sourceClosedId == "number") {
// sourceClosedId is used to look up the closed window to remove it when the tab is restored
let sourceClosedId = aClosedTab.sourceClosedId;
element.setAttribute("source-closed-id", sourceClosedId);
element.setAttribute("value", aClosedTab.closedId);
element.removeAttribute("oncommand");
element.addEventListener(
"command",
() => {
@@ -461,9 +462,8 @@ function createEntry(
let sourceWindowId = aClosedTab.sourceWindowId;
element.setAttribute("value", aIndex);
element.setAttribute("source-window-id", sourceWindowId);
element.setAttribute(
"oncommand",
`undoCloseTab(${aIndex}, "${sourceWindowId}");`
element.addEventListener("command", event =>
event.target.ownerGlobal.undoCloseTab(aIndex, sourceWindowId)
);
}