From 5ee0ea2cba91796118f927503fd2b42d8ad8fad0 Mon Sep 17 00:00:00 2001 From: Daniel Holbert Date: Tue, 6 May 2025 22:36:50 +0000 Subject: [PATCH] Bug 1964242: Remove WPT tests for element. r=longsonr The discard element was removed from the SVG spec in https://github.com/w3c/svgwg/pull/973 and we have a WPT test at svg/animations/historical.html to verify that it's not recognized. This patch here removes some older subtests that expect it to be supported. Differential Revision: https://phabricator.services.mozilla.com/D247807 --- .../meta/svg/idlharness.window.js.ini | 75 ------------------- ...entation-attributes-special-cases.html.ini | 3 - .../tests/interfaces/svg-animations.idl | 4 - .../tests/svg/idlharness.window.js | 2 - ...presentation-attributes-special-cases.html | 2 +- 5 files changed, 1 insertion(+), 85 deletions(-) diff --git a/testing/web-platform/meta/svg/idlharness.window.js.ini b/testing/web-platform/meta/svg/idlharness.window.js.ini index a86eab1e559b..a684d8ed6829 100644 --- a/testing/web-platform/meta/svg/idlharness.window.js.ini +++ b/testing/web-platform/meta/svg/idlharness.window.js.ini @@ -416,78 +416,3 @@ [SVGElement interface: objects.animateTransform must inherit property "correspondingUseElement" with the proper type] expected: FAIL - - [SVGDiscardElement interface: existence and properties of interface object] - expected: FAIL - - [SVGDiscardElement interface object length] - expected: FAIL - - [SVGDiscardElement interface object name] - expected: FAIL - - [SVGDiscardElement interface: existence and properties of interface prototype object] - expected: FAIL - - [SVGDiscardElement interface: existence and properties of interface prototype object's "constructor" property] - expected: FAIL - - [SVGDiscardElement interface: existence and properties of interface prototype object's @@unscopables property] - expected: FAIL - - [SVGDiscardElement must be primary interface of objects.discard] - expected: FAIL - - [Stringification of objects.discard] - expected: FAIL - - [SVGAnimationElement interface: objects.discard must inherit property "targetElement" with the proper type] - expected: FAIL - - [SVGAnimationElement interface: objects.discard must inherit property "onbegin" with the proper type] - expected: FAIL - - [SVGAnimationElement interface: objects.discard must inherit property "onend" with the proper type] - expected: FAIL - - [SVGAnimationElement interface: objects.discard must inherit property "onrepeat" with the proper type] - expected: FAIL - - [SVGAnimationElement interface: objects.discard must inherit property "getStartTime()" with the proper type] - expected: FAIL - - [SVGAnimationElement interface: objects.discard must inherit property "getCurrentTime()" with the proper type] - expected: FAIL - - [SVGAnimationElement interface: objects.discard must inherit property "getSimpleDuration()" with the proper type] - expected: FAIL - - [SVGAnimationElement interface: objects.discard must inherit property "beginElement()" with the proper type] - expected: FAIL - - [SVGAnimationElement interface: objects.discard must inherit property "beginElementAt(float)" with the proper type] - expected: FAIL - - [SVGAnimationElement interface: calling beginElementAt(float) on objects.discard with too few arguments must throw TypeError] - expected: FAIL - - [SVGAnimationElement interface: objects.discard must inherit property "endElement()" with the proper type] - expected: FAIL - - [SVGAnimationElement interface: objects.discard must inherit property "endElementAt(float)" with the proper type] - expected: FAIL - - [SVGAnimationElement interface: calling endElementAt(float) on objects.discard with too few arguments must throw TypeError] - expected: FAIL - - [SVGAnimationElement interface: objects.discard must inherit property "requiredExtensions" with the proper type] - expected: FAIL - - [SVGAnimationElement interface: objects.discard must inherit property "systemLanguage" with the proper type] - expected: FAIL - - [SVGElement interface: objects.discard must inherit property "correspondingElement" with the proper type] - expected: FAIL - - [SVGElement interface: objects.discard must inherit property "correspondingUseElement" with the proper type] - expected: FAIL diff --git a/testing/web-platform/meta/svg/styling/presentation-attributes-special-cases.html.ini b/testing/web-platform/meta/svg/styling/presentation-attributes-special-cases.html.ini index 3f4c603533b8..e3492bf8942e 100644 --- a/testing/web-platform/meta/svg/styling/presentation-attributes-special-cases.html.ini +++ b/testing/web-platform/meta/svg/styling/presentation-attributes-special-cases.html.ini @@ -7,6 +7,3 @@ [x, y, width, and height presentation attributes supported on use element] expected: FAIL - - [fill presentation attribute not supported on discard] - expected: FAIL diff --git a/testing/web-platform/tests/interfaces/svg-animations.idl b/testing/web-platform/tests/interfaces/svg-animations.idl index b57e1b9eb512..ba78c928b66d 100644 --- a/testing/web-platform/tests/interfaces/svg-animations.idl +++ b/testing/web-platform/tests/interfaces/svg-animations.idl @@ -55,10 +55,6 @@ SVGMPathElement includes SVGURIReference; interface SVGAnimateTransformElement : SVGAnimationElement { }; -[Exposed=Window] -interface SVGDiscardElement : SVGAnimationElement { -}; - partial interface SVGSVGElement { undefined pauseAnimations(); undefined unpauseAnimations(); diff --git a/testing/web-platform/tests/svg/idlharness.window.js b/testing/web-platform/tests/svg/idlharness.window.js index a26fa2bef6d7..57beca77fd45 100644 --- a/testing/web-platform/tests/svg/idlharness.window.js +++ b/testing/web-platform/tests/svg/idlharness.window.js @@ -42,7 +42,6 @@ const elements = [ 'script', 'animate', 'set', - 'discard', 'animateMotion', 'mpath', 'animateTransform', @@ -167,7 +166,6 @@ idl_test( SVGViewElement: ['objects.view'], SVGScriptElement: ['objects.script'], SVGAnimateElement: ['objects.animate'], - SVGDiscardElement: ['objects.discard'], SVGSetElement: ['objects.set'], SVGAnimateMotionElement: ['objects.animateMotion'], SVGMPathElement: ['objects.mpath'], diff --git a/testing/web-platform/tests/svg/styling/presentation-attributes-special-cases.html b/testing/web-platform/tests/svg/styling/presentation-attributes-special-cases.html index 7bfa001030a0..9a5da751ce1a 100644 --- a/testing/web-platform/tests/svg/styling/presentation-attributes-special-cases.html +++ b/testing/web-platform/tests/svg/styling/presentation-attributes-special-cases.html @@ -98,7 +98,7 @@ if (CSS.supports("d", "initial")) { // animation elements. if (CSS.supports("fill", "initial")) { - for (let e of ["animate", "animateMotion", "animateTransform", "discard", "set"]) { + for (let e of ["animate", "animateMotion", "animateTransform", "set"]) { test(function() { assertPresentationAttributeIsNotSupported(e, "fill", "blue", "fill"); }, `fill presentation attribute not supported on ${e}`);