corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1583052 - Don't null-check OwnerDoc() in HTMLMediaElement.cpp. r=smaug

Browse Source 
It can never return null.

Differential Revision: https://phabricator.services.mozilla.com/D46774
This commit is contained in:
Emilio Cobos Álvarez
2019-09-23 13:09:52 +00:00
parent ed0a614e97
commit 5d0eb782c1
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
dom/html/HTMLMediaElement.cpp
View File

@@ -856,10 +856,7 @@ HTMLMediaElement::MediaLoadListener::OnStartRequest(nsIRequest* aRequest) {
// array of blocked tracking nodes under its parent document.
if (net::UrlClassifierFeatureFactory::IsClassifierBlockingErrorCode(
status)) {
Document* ownerDoc = element->OwnerDoc();
if (ownerDoc) {
ownerDoc->AddBlockedNodeByClassifier(element);
}
element->OwnerDoc()->AddBlockedNodeByClassifier(element);
}
element->NotifyLoadError(
nsPrintfCString("%u: %s", uint32_t(status), "Request failed"));
@@ -5891,7 +5888,7 @@ void HTMLMediaElement::CheckAutoplayDataReady() {
bool HTMLMediaElement::IsActive() const {
Document* ownerDoc = OwnerDoc();
return ownerDoc && ownerDoc->IsActive() && ownerDoc->IsVisible();
return ownerDoc->IsActive() && ownerDoc->IsVisible();
}
bool HTMLMediaElement::IsHidden() const {
@@ -6211,8 +6208,7 @@ void HTMLMediaElement::SuspendOrResumeElement(bool aPauseElement,
}
bool HTMLMediaElement::IsBeingDestroyed() {
Document* ownerDoc = OwnerDoc();
nsIDocShell* docShell = ownerDoc ? ownerDoc->GetDocShell() : nullptr;
nsIDocShell* docShell = OwnerDoc()->GetDocShell();
bool isBeingDestroyed = false;
if (docShell) {
docShell->IsBeingDestroyed(&isBeingDestroyed);