Bug 1960383 - Remove vestigial logic related to browser.translations.panelShown r=nordzilla,translations-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D245636

browser/components/enterprisepolicies/Policies.sys.mjs

@@ -2641,9 +2641,22 @@ export var Policies = {
           param.FeatureRecommendations,
           param.Locked
         );
+
+        // We use the mostRecentTargetLanguages pref to control the
+        // translations panel intro. Setting a language value simulates a
+        // first translation, which skips the intro panel for users with
+        // FeatureRecommendations disabled.
+        const topWebPreferredLanguage = Services.prefs
+          .getComplexValue("intl.accept_languages", Ci.nsIPrefLocalizedString)
+          .data.split(/\s*,\s*/g)[0];
+
+        const preferredLanguage = topWebPreferredLanguage.length
+          ? topWebPreferredLanguage
+          : Services.locale.appLocaleAsBCP47;
+
         PoliciesUtils.setDefaultPref(
-          "browser.translations.panelShown",
-          !param.FeatureRecommendations,
+          "browser.translations.mostRecentTargetLanguages",
+          param.FeatureRecommendations ? "" : preferredLanguage,
           param.Locked
         );
       }

browser/components/translations/tests/browser/browser_translations_full_page_telemetry_auto_translate.js

@@ -11,7 +11,6 @@ add_task(async function test_translations_telemetry_auto_translate() {
   const { cleanup, resolveDownloads, runInPage } = await loadTestPage({
     page: SPANISH_PAGE_URL,
     languagePairs: LANGUAGE_PAIRS,
-    prefs: [["browser.translations.panelShown", false]],
   });
 
   await FullPageTranslationsTestUtils.assertTranslationsButton(

browser/components/translations/tests/browser/browser_translations_full_page_telemetry_basics.js

@@ -10,7 +10,6 @@ add_task(async function test_translations_telemetry_basics() {
   const { cleanup } = await loadTestPage({
     page: SPANISH_PAGE_URL,
     languagePairs: LANGUAGE_PAIRS,
-    prefs: [["browser.translations.panelShown", false]],
   });
 
   await TestTranslationsTelemetry.assertEvent(Glean.translationsPanel.open, {

browser/components/translations/tests/browser/browser_translations_full_page_telemetry_unsupported_lang.js

@@ -14,7 +14,6 @@ add_task(async function test_translations_telemetry_unsupported_lang() {
       { fromLang: "fr", toLang: "en" },
       { fromLang: "en", toLang: "fr" },
     ],
-    prefs: [["browser.translations.panelShown", false]],
   });
 
   await FullPageTranslationsTestUtils.openPanel({

toolkit/components/translations/actors/TranslationsParent.sys.mjs

@@ -425,17 +425,6 @@ export class TranslationsParent extends JSWindowActorParent {
    */
   resolveEngine = null;
 
-  /**
-   * The cached URI spec where the panel was first ever shown, as determined by the
-   * browser.translations.panelShown pref.
-   *
-   * Holding on to this URI value allows us to show the introductory message in the panel
-   * when the panel opens, as long as the active panel is open on that particular URI.
-   *
-   * @type {string | null}
-   */
-  firstShowUriSpec = null;
-
   /**
    * The TranslationsEngineParent instance which requests from this
    * TranslationsParent are being handled by.

toolkit/components/translations/tests/browser/shared-head.js

@@ -1050,7 +1050,6 @@ async function loadTestPage({
         // Enabled by default.
         ["browser.translations.enable", true],
         ["browser.translations.logLevel", "All"],
-        ["browser.translations.panelShown", true],
         ["browser.translations.automaticallyPopup", true],
         ["browser.translations.alwaysTranslateLanguages", ""],
         ["browser.translations.neverTranslateLanguages", ""],