Bug 1957867 - Fix eslint ignore for paths containing target r=frontend-codestyle-reviewers,devtools-reviewers,Standard8,ochameau

Differential Revision: https://phabricator.services.mozilla.com/D244130

.eslintrc-ignores.js

@@ -239,11 +239,11 @@ module.exports = [
   "servo/",
 
   // Rust/Cargo output from running `cargo` directly
-  "target/",
-  "servo/ports/geckolib/target/",
-  "dom/base/rust/target/",
-  "servo/components/style/target/",
-  "dom/webgpu/tests/cts/vendor/target/",
+  "/target/",
+  "/servo/ports/geckolib/target/",
+  "/dom/base/rust/target/",
+  "/servo/components/style/target/",
+  "/dom/webgpu/tests/cts/vendor/target/",
 
   // Test files that we don't want to lint (preprocessed, minified etc)
   "testing/condprofile/condprof/tests/profile",

devtools/shared/commands/target/target-command.js

@@ -194,6 +194,7 @@ class TargetCommand extends EventEmitter {
   // Called whenever a new Target front is available.
   // Either because a target was already available as we started calling startListening
   // or if it has just been created
+  // eslint-disable-next-line complexity
   async _onTargetAvailable(targetFront) {
     // We put the `commands` on the targetFront so it can be retrieved from any front easily.
     // Without this, protocol.js fronts won't have any easy access to it.
@@ -1154,12 +1155,12 @@ class TargetCommand extends EventEmitter {
    * @param {WindowGlobalTargetFront} targetFront
    *        The target front we want the toolbox to focus on.
    */
-  selectTarget(targetFront) {
+  async selectTarget(targetFront) {
     // Ignore any target which we may try to select, but is already being destroyed
     if (targetFront.isDestroyedOrBeingDestroyed()) {
       return;
     }
-    return this._onTargetSelected(targetFront);
+    await this._onTargetSelected(targetFront);
   }
 
   /**

devtools/shared/commands/target/tests/browser_target_command_bfcache.js

@@ -415,7 +415,7 @@ async function testIframeNavigations() {
   info(" # Test IFRAME navigations");
   // Create a TargetCommand for a given test tab
   const tab = await addTab(
-    `http://example.org/document-builder.sjs?html=<iframe src="${TEST_COM_URL}"></iframe>`
+    `https://example.org/document-builder.sjs?html=<iframe src="${TEST_COM_URL}"></iframe>`
   );
   const commands = await CommandsFactory.forTab(tab);
   const targetCommand = commands.targetCommand;

devtools/shared/commands/target/tests/browser_target_command_content_scripts.js

@@ -26,6 +26,7 @@ add_task(async function () {
     },
     files: {
       "content-script.js": function () {
+        // eslint-disable-next-line no-undef
         browser.test.notifyPass("contentScriptRan");
       },
     },
@@ -149,6 +150,7 @@ add_task(async function () {
     },
     files: {
       "content-script.js": function () {
+        // eslint-disable-next-line no-undef
         browser.test.notifyPass("contentScriptRan");
       },
     },

devtools/shared/commands/target/tests/browser_target_command_reload.js

@@ -86,7 +86,7 @@ add_task(async function () {
   await targetCommand.startListening();
 
   // Observe the new document being reported while reloading
-  let reloadedTargets = [];
+  const reloadedTargets = [];
   await commands.resourceCommand.watchResources(
     [commands.resourceCommand.TYPES.DOCUMENT_EVENT],
     {

devtools/shared/commands/target/tests/helper_service_workers_navigation.js

@@ -5,12 +5,14 @@
 
 /* import-globals-from head.js */
 
+/* exported setupServiceWorkerNavigationTest */
 async function setupServiceWorkerNavigationTest() {
   // Disable the preloaded process as it creates processes intermittently
   // which forces the emission of RDP requests we aren't correctly waiting for.
   await pushPref("dom.ipc.processPrelaunch.enabled", false);
 }
 
+/* exported watchServiceWorkerTargets */
 async function watchServiceWorkerTargets(tab) {
   info("Create a target list for a tab target");
   const commands = await CommandsFactory.forTab(tab);
@@ -52,6 +54,7 @@ async function watchServiceWorkerTargets(tab) {
 /**
  * Wait until the expected URL is loaded and win.registration has resolved.
  */
+/* exported waitForRegistrationReady */
 async function waitForRegistrationReady(tab, expectedPageUrl, workerUrl) {
   await asyncWaitUntil(() =>
     SpecialPowers.spawn(tab.linkedBrowser, [expectedPageUrl], function (_url) {
@@ -92,6 +95,7 @@ async function waitForRegistrationReady(tab, expectedPageUrl, workerUrl) {
  * onDestroyed callbacks. Assert that the callbacks have been called the
  * expected number of times, with the expected targets.
  */
+/* exported checkHooks */
 async function checkHooks(hooks, { available, destroyed, targets }) {
   await waitUntil(
     () => hooks.availableCount == available && hooks.destroyedCount == destroyed