corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D176791
This commit is contained in:
Itiel
2023-06-12 17:16:35 +00:00
parent 3663ea8e74
commit 548aeccf66
38 changed files with 165 additions and 190 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
browser/components/urlbar/UrlbarInput.sys.mjs
View File

@@ -4153,11 +4153,9 @@ class AddSearchEngineHelper {
elt.setAttribute("anonid", `add-engine-${index}`);
elt.classList.add("menuitem-iconic");
elt.classList.add("context-menu-add-engine");
elt.setAttribute("data-l10n-id", "search-one-offs-add-engine");
elt.setAttribute(
"data-l10n-args",
JSON.stringify({ engineName: engine.title })
);
this.input.document.l10n.setAttributes(elt, "search-one-offs-add-engine", {
engineName: engine.title,
});
elt.setAttribute("uri", engine.uri);
if (engine.icon) {
elt.setAttribute("image", engine.icon);
@@ -4173,7 +4171,10 @@ class AddSearchEngineHelper {
elt.setAttribute("anonid", "add-engine-menu");
elt.classList.add("menu-iconic");
elt.classList.add("context-menu-add-engine");
elt.setAttribute("data-l10n-id", "search-one-offs-add-engine-menu");
this.input.document.l10n.setAttributes(
elt,
"search-one-offs-add-engine-menu"
);
if (engine.icon) {
elt.setAttribute("image", engine.icon);
}