corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1805365 - Part 1: Allow mp2 files distributed within wav containers to retain an .mp2 extension when saving to disk. r=padenot

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D250371
This commit is contained in:
az
2025-05-22 12:16:21 +00:00
committed by azebrowski@mozilla.com
parent 1977cec6e3
commit 53b401be9a
1 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
uriloader/exthandler/nsExternalHelperAppService.cpp
View File

@@ -3768,13 +3768,18 @@ nsExternalHelperAppService::ShouldModifyExtension(nsIMIMEInfo* aMimeInfo,
return ModifyExtension_Append;
}
// MIME type video/3gpp is a special case as 3gpp is (mostly) MP4 compatible
// and often saved as .mp4. If so, we want to avoid changing the extension
// since .3gpp is uncommon and confuses users (see: bug 1749294)
if (MIMEType.Equals("video/3gpp")) {
// Special cases where we want to keep file extensions if they're common
// for a given MIME type to avoid surprising users with a changed extension.
static constexpr std::pair<nsLiteralCString, nsLiteralCString>
ignoreMimeExtPairs[] = {
{"video/3gpp"_ns, "mp4"_ns}, // bug 1749294
{"audio/x-wav"_ns, "mp2"_ns}, // bug 1805365
};
nsAutoCString fileExtLowerCase(aFileExt);
ToLowerCase(fileExtLowerCase);
if (fileExtLowerCase.Equals("mp4")) {
for (const auto& [mime, ext] : ignoreMimeExtPairs) {
if (MIMEType.Equals(mime) && fileExtLowerCase.Equals(ext)) {
return ModifyExtension_Ignore;
}
}