corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't just undepend the string, canonicalize it as well.

Browse Source
This commit is contained in:
Blake Kaplan
2008-08-14 17:31:39 -07:00
parent f3c5bde00c
commit 5212c28ec4
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
js/src/jsbuiltins.cpp
View File

@@ -379,9 +379,11 @@ jsval FASTCALL
js_Any_getelem(JSContext* cx, JSObject* obj, JSString* idstr)
{
jsval v;
if (!JSSTRING_IS_FLAT(idstr) && !js_UndependString(cx, idstr))
jsid id;
if (!js_ValueToStringId(cx, STRING_TO_JSVAL(idstr), &id))
return JSVAL_ERROR_COOKIE;
if (!OBJ_GET_PROPERTY(cx, obj, ATOM_TO_JSID(STRING_TO_JSVAL(idstr)), &v))
if (!OBJ_GET_PROPERTY(cx, obj, id, &v))
return JSVAL_ERROR_COOKIE;
return v;
}
@@ -389,9 +391,10 @@ js_Any_getelem(JSContext* cx, JSObject* obj, JSString* idstr)
bool FASTCALL
js_Any_setelem(JSContext* cx, JSObject* obj, JSString* idstr, jsval v)
{
if (!JSSTRING_IS_FLAT(idstr) && !js_UndependString(cx, idstr))
jsid id;
if (!js_ValueToStringId(cx, STRING_TO_JSVAL(idstr), &id))
return false;
return OBJ_SET_PROPERTY(cx, obj, ATOM_TO_JSID(STRING_TO_JSVAL(idstr)), &v);
return OBJ_SET_PROPERTY(cx, obj, id, &v);
}
JSObject* FASTCALL