corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 878606 - Only measure SSL UI clicks for top level frames. r=felipc

Browse Source
This commit is contained in:
Devdatta Akhawe
2013-06-04 15:02:24 -07:00
parent dead4d0bda
commit 51974060c6
4 changed files with 48 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
docshell/base/nsDocShell.cpp
View File

@@ -4247,9 +4247,9 @@ nsDocShell::DisplayLoadError(nsresult aError, nsIURI *aURI,
cssClass.AssignLiteral("badStsCert");
//measuring STS separately allows us to measure click through
//rates easily
bucketId = nsISecurityUITelemetry::WARNING_BAD_CERT_STS;
bucketId = nsISecurityUITelemetry::WARNING_BAD_CERT_TOP_STS;
} else {
bucketId = nsISecurityUITelemetry::WARNING_BAD_CERT;
bucketId = nsISecurityUITelemetry::WARNING_BAD_CERT_TOP;
}
@@ -4265,7 +4265,7 @@ nsDocShell::DisplayLoadError(nsresult aError, nsIURI *aURI,
if (alternateErrorPage)
errorPage.Assign(alternateErrorPage);
if (errorPage.EqualsIgnoreCase("certerror"))
if (!IsFrame() && errorPage.EqualsIgnoreCase("certerror"))
mozilla::Telemetry::Accumulate(mozilla::Telemetry::SECURITY_UI, bucketId);
} else {