Bug 1936036 - Replace flag histogram MASTER_PASSWORD_ENABLED r=mtigley,firefox-desktop-core-reviewers ,mossop

Differential Revision: https://phabricator.services.mozilla.com/D231559

browser/components/BrowserGlue.sys.mjs

@@ -3262,12 +3262,7 @@ BrowserGlue.prototype = {
           Ci.nsIPK11TokenDB
         );
         let token = tokenDB.getInternalKeyToken();
-        let mpEnabled = token.hasPassword;
+        Glean.primaryPassword.enabled.set(token.hasPassword);
-        if (mpEnabled) {
-          Services.telemetry
-            .getHistogramById("MASTER_PASSWORD_ENABLED")
-            .add(mpEnabled);
-        }
       },
 
       function GMPInstallManagerSimpleCheckAndInstall() {

browser/components/metrics.yaml

@@ -739,3 +739,19 @@ security:
     expires: never
     unit: unknown
     telemetry_mirror: SECURITY_GLOBAL_PRIVACY_CONTROL_ENABLED
+
+primary.password:
+  enabled:
+    type: boolean
+    description: >
+      If a primary-password is enabled for this profile.
+      Set soon after browser startup.
+      Does not update if a primary password is added or removed after startup.
+    bugs:
+      - https://bugzil.la/1936036
+    data_reviews:
+      - https://bugzil.la/1936036
+    notification_emails:
+      - mtigley@mozilla.com
+    expires: never
+    telemetry_mirror: PRIMARY_PASSWORD_ENABLED

toolkit/components/telemetry/Histograms.json

@@ -11222,14 +11222,6 @@
     "n_values": 30,
     "description": "Algorithms used with WebCrypto (see table in WebCryptoTask.cpp)"
   },
-  "MASTER_PASSWORD_ENABLED": {
-    "record_in_processes": ["main", "content"],
-    "products": ["firefox", "fennec"],
-    "expires_in_version": "never",
-    "releaseChannelCollection": "opt-out",
-    "kind": "flag",
-    "description": "If a primary-password is enabled for this profile"
-  },
   "DISPLAY_SCALING": {
     "record_in_processes": ["main", "content"],
     "products": ["firefox", "fennec"],

toolkit/components/telemetry/Scalars.yaml

@@ -7654,6 +7654,24 @@ power:
     record_in_processes:
       - 'all'
 
+primary.password:
+  enabled:
+    kind: boolean
+    description:
+      If a primary-password is enabled for this profile.
+      Set soon after browser startup.
+      Does not update if a primary password is added or removed after startup.
+    bug_numbers:
+      - 1936036
+    expires: never
+    notification_emails:
+      - mtigley@mozilla.com
+    release_channel_collection: opt-out
+    products:
+      - 'firefox'
+    record_in_processes:
+      - 'all'
+
 # The following section is for probes testing the Telemetry system. They will not be
 # submitted in pings and are only used for testing.
 telemetry.test:

toolkit/components/telemetry/histogram-allowlists.json

@@ -83,7 +83,6 @@
     "LOCALDOMSTORAGE_SHUTDOWN_DATABASE_MS",
     "LONG_REFLOW_INTERRUPTIBLE",
     "MAC_INITFONTLIST_TOTAL",
-    "MASTER_PASSWORD_ENABLED",
     "MIXED_CONTENT_PAGE_LOAD",
     "MIXED_CONTENT_UNBLOCK_COUNTER",
     "MOZ_SQLITE_COOKIES_OPEN_READAHEAD_MS",
@@ -310,7 +309,6 @@
     "LOCALDOMSTORAGE_SHUTDOWN_DATABASE_MS",
     "LONG_REFLOW_INTERRUPTIBLE",
     "MAC_INITFONTLIST_TOTAL",
-    "MASTER_PASSWORD_ENABLED",
     "MEDIA_CODEC_USED",
     "MEMORY_FREE_PURGED_PAGES_MS",
     "MEMORY_HEAP_ALLOCATED",
@@ -654,7 +652,6 @@
     "FX_CONTENT_CRASH_DUMP_UNAVAILABLE",
     "FX_CONTENT_CRASH_NOT_SUBMITTED",
     "GEOLOCATION_ERROR",
-    "MASTER_PASSWORD_ENABLED",
     "MEDIA_CODEC_USED",
     "PERMISSIONS_SQL_CORRUPTED",
     "PROCESS_CRASH_SUBMIT_ATTEMPT",