Bug 1667915 - Separate marker category from marker options - r=gregtatum
The `category.WithOptions(...)` syntax was a bit strange and difficult to explain.
Now the category and options are separate parameters. Default options can be specified with `MarkerOptions{}` or just `{}`.
As a special case, defaulted-NoPayload functions don't need `<>`, and defaulted-NoPayload functions and macros don't even need `{}` for default options, e.g.:
`profiler_add_marker("name", OTHER); PROFILER_MARKER_UNTYPED("name", OTHER);`
Differential Revision: https://phabricator.services.mozilla.com/D91680
This commit is contained in:
@@ -2365,10 +2365,9 @@ void RecordCompositionPayloadsPresented(
|
||||
nsPrintfCString text(
|
||||
"Latency: %dms",
|
||||
int32_t((presented - payload.mTimeStamp).ToMilliseconds()));
|
||||
PROFILER_MARKER_TEXT(name,
|
||||
GRAPHICS.WithOptions(MarkerTiming::Interval(
|
||||
payload.mTimeStamp, presented)),
|
||||
text);
|
||||
PROFILER_MARKER_TEXT(
|
||||
name, GRAPHICS,
|
||||
MarkerTiming::Interval(payload.mTimeStamp, presented), text);
|
||||
}
|
||||
#endif
|
||||
|
||||
|
||||
Reference in New Issue
Block a user