corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1710283 - Null-check lazyload intersection observers on unregistration. r=sefeng

Browse Source 
It seems plausible for the doc to be unlinked, or for the element to be moved
to another document, in between the time observer notification is scheduled and
the time it runs. In that case, we'd be unregistered already anyways, so
there's nothing else to do.

Differential Revision: https://phabricator.services.mozilla.com/D114740
This commit is contained in:
Emilio Cobos Alvarez
2021-05-10 14:53:07 +00:00
parent cfe43e85f7
commit 4bed802a7c
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
dom/html/HTMLImageElement.cpp
View File

@@ -1293,13 +1293,17 @@ void HTMLImageElement::StopLazyLoading(
}
mLazyLoading = false;
Document* doc = OwnerDoc();
doc->GetLazyLoadImageObserver()->Unobserve(*this);
if (auto* obs = doc->GetLazyLoadImageObserver()) {
obs->Unobserve(*this);
}
if (bool(aFromIntersectionObserver)) {
doc->IncLazyLoadImageStarted();
} else {
doc->DecLazyLoadImageCount();
doc->GetLazyLoadImageObserverViewport()->Unobserve(*this);
if (auto* obs = doc->GetLazyLoadImageObserverViewport()) {
obs->Unobserve(*this);
}
}
if (bool(aStartLoading)) {
@@ -1309,7 +1313,9 @@ void HTMLImageElement::StopLazyLoading(
void HTMLImageElement::LazyLoadImageReachedViewport() {
Document* doc = OwnerDoc();
doc->GetLazyLoadImageObserverViewport()->Unobserve(*this);
if (auto* obs = doc->GetLazyLoadImageObserverViewport()) {
obs->Unobserve(*this);
}
doc->IncLazyLoadImageReachViewport(!Complete());
}