corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1919598 - Land Firefox View Discoverability treatment-b in mc- r=omc-reviewers,fluent-reviewers,emcminn,accessibility-frontend-reviewers,nstroud

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D229198
This commit is contained in:
negin
2025-02-24 15:21:41 +00:00
parent bd4017c5ee
commit 4b16185899
6 changed files with 215 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
browser/components/asrouter/modules/ASRouter.sys.mjs
View File

@@ -1385,7 +1385,7 @@ export class _ASRouter {
return { message: {} };
}
// filter out messages we want to exclude from tests
// Filters out messages we want to exclude from tests
if (
message.skip_in_tests &&
// `this.messagesEnabledInAutomation` should be stubbed in tests

159
browser/components/asrouter/modules/FeatureCalloutMessages.sys.mjs
View File

@@ -2493,6 +2493,165 @@ const MESSAGES = () => {
skip_in_tests:
"not tested in automation and might pop up unexpectedly during review checker tests",
},
{
id: "FX_VIEW_DISCOVERABILITY_ALL_USERS",
template: "feature_callout",
groups: ["cfr"],
content: {
id: "FX_VIEW_DISCOVERABILITY_ALL_USERS",
template: "multistage",
backdrop: "transparent",
transitions: false,
screens: [
{
id: "FX_VIEW_DISCOVERABILITY_ALL_USERS_SCREEN",
anchors: [
{
selector: "#firefox-view-button",
panel_position: {
anchor_attachment: "bottomcenter",
callout_attachment: "topleft",
},
no_open_on_anchor: true,
arrow_width: "15.5563",
},
],
content: {
position: "callout",
width: "342px",
padding: 16,
page_event_listeners: [
{
params: {
type: "click",
selectors: "#firefox-view-button",
},
action: {
dismiss: true,
},
},
],
title_logo: {
imageURL:
"chrome://browser/content/asrouter/assets/fox-question-mark-icon.svg",
width: "25px",
height: "29px",
marginInline: "4px 14px",
alignment: "top",
},
title: {
string_id: "fx-view-discoverability-title",
marginInline: "0 16px",
},
subtitle: {
string_id: "fx-view-discoverability-subtitle",
paddingInline: "34px 0",
marginBlock: "-8px -4px",
},
additional_button: {
label: {
string_id: "fx-view-discoverability-secondary-button-label",
},
style: "secondary",
action: {
type: "BLOCK_MESSAGE",
data: {
id: "FX_VIEW_DISCOVERABILITY_ALL_USERS",
},
dismiss: true,
},
},
secondary_button: {
label: {
string_id: "fx-view-discoverability-primary-button-label",
},
style: "primary",
action: {
type: "OPEN_FIREFOX_VIEW",
navigate: true,
},
},
submenu_button: {
submenu: [
{
type: "action",
label: {
string_id: "split-dismiss-button-dont-show-option",
},
action: {
type: "BLOCK_MESSAGE",
data: {
id: "FX_VIEW_DISCOVERABILITY_ALL_USERS",
},
dismiss: true,
},
id: "block_recommendation",
},
{
type: "action",
label: {
string_id: "split-dismiss-button-show-fewer-option",
},
action: {
type: "MULTI_ACTION",
dismiss: true,
data: {
actions: [
{
type: "SET_PREF",
data: {
pref: {
name: "messaging-system-action.firefox-view-recommendations",
value: true,
},
},
},
{
type: "BLOCK_MESSAGE",
data: {
id: "FX_VIEW_DISCOVERABILITY_ALL_USERS",
},
},
],
},
},
id: "show_fewer_recommendations",
},
{
type: "separator",
},
{
type: "action",
label: {
string_id: "split-dismiss-button-manage-settings-option",
},
action: {
type: "OPEN_ABOUT_PAGE",
data: {
args: "preferences#general-cfrfeatures",
where: "tab",
},
dismiss: true,
},
id: "manage_settings",
},
],
attached_to: "additional_button",
},
},
},
],
},
frequency: {
lifetime: 1,
},
skip_in_tests: "not tested in automation",
targeting:
"!isMajorUpgrade && !willShowDefaultPrompt && !activeNotifications && previousSessionEnd && fxViewButtonAreaType != null && tabsClosedCount >= 5 && (currentDate|date - profileAgeCreated|date) / 86400000 >= 7 && 'browser.newtabpage.activity-stream.asrouter.userprefs.cfr.features' | preferenceValue != false",
trigger: {
id: "nthTabClosed",
},
},
];
messages = add24HourImpressionJEXLTargeting(
["FIREFOX_VIEW_TAB_PICKUP_REMINDER"],