Bug 1113369, part 2 - js::SetArrayLength ObjectOpResult support. r=Waldo.

2015-01-29 23:02:26 -06:00
parent f25a0ce728
commit 4a1c7e47a8
7 changed files with 79 additions and 47 deletions
--- a/js/src/jsobj.cpp
+++ b/js/src/jsobj.cpp
@@ -792,11 +792,7 @@ DefinePropertyOnArray(JSContext *cx, Handle<ArrayObject*> arr, HandleId id, cons
                attrs = attrs | JSPROP_READONLY;
        }

-        // XXX Temporarily break compatibility here. The right thing is to pass
-        // result on to ArraySetLength.
-        if (!ArraySetLength(cx, arr, id, attrs, v, false))
-            return false;
-        return result.succeed();
+        return ArraySetLength(cx, arr, id, attrs, v, result);
    }

    /* Step 3. */