corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 940033 - js::HashMapEntry::{key,value} fields should be private, with accessors, and the former should expose a const reference. r=jimb

Browse Source
This commit is contained in:
Jeff Walden
2013-11-25 17:35:09 -08:00
parent ca5f2790d2
commit 49bc3140ce
48 changed files with 309 additions and 290 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
js/ipc/JavaScriptShared.cpp
View File

@@ -30,9 +30,9 @@ void
ObjectStore::trace(JSTracer *trc)
{
for (ObjectTable::Range r(table_.all()); !r.empty(); r.popFront()) {
DebugOnly<JSObject *> prior = r.front().value.get();
JS_CallHeapObjectTracer(trc, &r.front().value, "ipc-object");
MOZ_ASSERT(r.front().value == prior);
DebugOnly<JSObject *> prior = r.front().value().get();
JS_CallHeapObjectTracer(trc, &r.front().value(), "ipc-object");
MOZ_ASSERT(r.front().value() == prior);
}
}
@@ -42,7 +42,7 @@ ObjectStore::find(ObjectId id)
ObjectTable::Ptr p = table_.lookup(id);
if (!p)
return nullptr;
return p->value;
return p->value();
}
bool
@@ -82,9 +82,9 @@ void
ObjectIdCache::trace(JSTracer *trc)
{
for (ObjectIdTable::Range r(table_->all()); !r.empty(); r.popFront()) {
JSObject *obj = r.front().key;
JSObject *obj = r.front().key();
JS_CallObjectTracer(trc, &obj, "ipc-id");
MOZ_ASSERT(obj == r.front().key);
MOZ_ASSERT(obj == r.front().key());
}
}
@@ -94,7 +94,7 @@ ObjectIdCache::find(JSObject *obj)
ObjectIdTable::Ptr p = table_->lookup(obj);
if (!p)
return 0;
return p->value;
return p->value();
}
bool