corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1372349 - Use LookupForAdd instead of GetWeak+Put to avoid unnecessary hashtable lookups. r=froydnj

Browse Source 
MozReview-Commit-ID: 37FVkb3vOO4
This commit is contained in:
Mats Palmgren
2017-06-14 17:27:25 +02:00
parent 1fcbae399f
commit 4823b50201
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
dom/html/HTMLAllCollection.cpp
View File

@@ -111,15 +111,12 @@ DocAllResultMatch(Element* aElement, int32_t aNamespaceID, nsIAtom* aAtom,
nsContentList*
HTMLAllCollection::GetDocumentAllList(const nsAString& aID)
{
if (nsContentList* docAllList = mNamedMap.GetWeak(aID)) {
return docAllList;
}
nsCOMPtr<nsIAtom> id = NS_Atomize(aID);
RefPtr<nsContentList> docAllList =
new nsContentList(mDocument, DocAllResultMatch, nullptr, nullptr, true, id);
mNamedMap.Put(aID, docAllList);
return docAllList;
return mNamedMap.LookupForAdd(aID).OrInsert(
[this, &aID] () {
nsCOMPtr<nsIAtom> id = NS_Atomize(aID);
return new nsContentList(mDocument, DocAllResultMatch, nullptr,
nullptr, true, id);
});
}
void