corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1974445 - Linux sandbox: filter send/recv flags for socket process. a=diannaS

Browse Source 
Original Revision: https://phabricator.services.mozilla.com/D255743

Differential Revision: https://phabricator.services.mozilla.com/D259016
This commit is contained in:
Jed Davis
2025-07-31 19:29:52 +00:00
committed by dsmith@mozilla.com
parent d6f73cfef5
commit 47e3221ff1
2 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
security/sandbox/common/test/SandboxTestingChildTests.h
View File

@@ -728,6 +728,11 @@ void RunTestsSocket(SandboxTestingChild* child) {
return 0; return 0;
}); });
child->ErrnoValueTest("send_with_flag"_ns, ENOSYS, [] {
char c = 0;
return send(0, &c, 1, MSG_OOB);
});
child->ErrnoValueTest("ioctl_dma_buf"_ns, ENOSYS, [] { child->ErrnoValueTest("ioctl_dma_buf"_ns, ENOSYS, [] {
// Attempt an arbitrary non-tty ioctl, on the wrong type of fd; if // Attempt an arbitrary non-tty ioctl, on the wrong type of fd; if
// allowed it would fail with ENOTTY (see the RDD tests) but in // allowed it would fail with ENOTTY (see the RDD tests) but in

12
security/sandbox/linux/SandboxFilter.cpp
View File

@@ -2161,10 +2161,14 @@ class SocketProcessSandboxPolicy final : public SandboxPolicyCommon {
} }
BoolExpr MsgFlagsAllowed(const Arg<int>& aFlags) const override { BoolExpr MsgFlagsAllowed(const Arg<int>& aFlags) const override {
// Allow everything for Necko, for now; this can be restricted // Necko might use advanced networking features, and the sandbox
// later (and the socket process sandbox is already relatively // is relatively permissive compared to content, so this is a
// permissive). // default-allow policy.
return BoolConst(true); //
// However, `MSG_OOB` has historically been buggy, and the way it
// maps to TCP is notoriously broken (see RFC 6093), so it should
// be safe to block.
return (aFlags & MSG_OOB) == 0;
} }
Maybe<ResultExpr> EvaluateSocketCall(int aCall, Maybe<ResultExpr> EvaluateSocketCall(int aCall,