corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1907967 - Change printfs for logging synthesizing mouse moves to MOZ_LOG r=smaug

Browse Source 
I think that it should be available only in the debug build for the performance.

Differential Revision: https://phabricator.services.mozilla.com/D217079
This commit is contained in:
Masayuki Nakano
2024-07-20 02:28:57 +00:00
parent b7d4e92909
commit 46df5e10d3
1 changed files with 38 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
layout/base/PresShell.cpp
View File

@@ -611,6 +611,15 @@ int16_t PresShell::sMouseButtons = MouseButtonsFlag::eNoButtons;
LazyLogModule PresShell::gLog("PresShell");
#ifdef DEBUG
// MouseLocation logs the mouse location and when/where enqueued synthesized
// mouse move is flushed. If you don't need all mouse location recording at
// eMouseMove, you can use MouseLocation:3,sync. Then, it's logged once per
// 50 times. Otherwise, if you need to log all eMouseMove locations, you can
// use MouseLocation:5,sync.
LazyLogModule gLogMouseLocation("MouseLocation");
#endif
TimeStamp PresShell::EventHandler::sLastInputCreated;
TimeStamp PresShell::EventHandler::sLastInputProcessed;
StaticRefPtr<Element> PresShell::EventHandler::sLastKeyDownEventTargetElement;
@@ -5799,9 +5808,10 @@ void PresShell::ProcessSynthMouseMoveEvent(bool aFromScroll) {
// we need to access members after we call DispatchEvent).
RefPtr<PresShell> kungFuDeathGrip(this);
#ifdef DEBUG_MOUSE_LOCATION
printf("[ps=%p]synthesizing mouse move to (%d,%d)\n", this, mMouseLocation.x,
mMouseLocation.y);
#ifdef DEBUG
MOZ_LOG(gLogMouseLocation, LogLevel::Info,
("[ps=%p]synthesizing mouse move to (%d,%d)\n", this,
mMouseLocation.x, mMouseLocation.y));
#endif
int32_t APD = mPresContext->AppUnitsPerDevPixel();
@@ -6766,12 +6776,28 @@ void PresShell::RecordPointerLocation(WidgetGUIEvent* aEvent) {
mMouseEventTargetGuid = InputAPZContext::GetTargetLayerGuid();
mMouseLocationWasSetBySynthesizedMouseEventForTests =
aEvent->mFlags.mIsSynthesizedForTests;
#ifdef DEBUG_MOUSE_LOCATION
if (aEvent->mMessage == eMouseEnterIntoWidget) {
printf("[ps=%p]got mouse enter for %p\n", this, aEvent->mWidget);
#ifdef DEBUG
if (MOZ_LOG_TEST(gLogMouseLocation, LogLevel::Info)) {
static uint32_t sFrequentMessageCount = 0;
const bool isFrequestMessage =
aEvent->mMessage == eMouseMove || aEvent->mMessage == eDragOver;
if (!isFrequestMessage ||
MOZ_LOG_TEST(gLogMouseLocation, LogLevel::Verbose) ||
!(sFrequentMessageCount % 50)) {
MOZ_LOG(gLogMouseLocation,
isFrequestMessage ? LogLevel::Debug : LogLevel::Info,
("[ps=%p]got %s for %p at {%d, %d}\n", this,
ToChar(aEvent->mMessage), aEvent->mWidget.get(),
mMouseLocation.x, mMouseLocation.y));
}
if (isFrequestMessage) {
sFrequentMessageCount++;
} else {
// Let's log the next eMouseMove or eDragOver after the other
// messages.
sFrequentMessageCount = 0;
}
}
printf("[ps=%p]setting mouse location to (%d,%d)\n", this,
mMouseLocation.x, mMouseLocation.y);
#endif
if (aEvent->mMessage == eMouseEnterIntoWidget) {
SynthesizeMouseMove(false);
@@ -6789,9 +6815,10 @@ void PresShell::RecordPointerLocation(WidgetGUIEvent* aEvent) {
mMouseEventTargetGuid = InputAPZContext::GetTargetLayerGuid();
mMouseLocationWasSetBySynthesizedMouseEventForTests =
aEvent->mFlags.mIsSynthesizedForTests;
#ifdef DEBUG_MOUSE_LOCATION
printf("[ps=%p]got mouse exit for %p\n", this, aEvent->mWidget);
printf("[ps=%p]clearing mouse location\n", this);
#ifdef DEBUG
MOZ_LOG(gLogMouseLocation, LogLevel::Info,
("[ps=%p]got %s for %p, mouse location is cleared\n", this,
ToChar(aEvent->mMessage), aEvent->mWidget.get()));
#endif
break;
}