175932. UMR: PostTimerEvent() does not check return value from GetPRThread(). Thanks to Andrew Schultz for pointing this out. r=pavlov, sr=darin. Also includes 175440 - using nsCOMArray in nsThreadPool, patch by bzbarsky@mit.edu

2002-11-08 04:46:58 +00:00
parent 5c8486e8fc
commit 468edb4f54
3 changed files with 33 additions and 48 deletions
--- a/xpcom/threads/nsTimerImpl.cpp
+++ b/xpcom/threads/nsTimerImpl.cpp
@@ -471,7 +471,11 @@ void nsTimerImpl::PostTimerEvent()
  }

  PRThread *thread;
-  mCallingThread->GetPRThread(&thread);
+  nsresult rv = mCallingThread->GetPRThread(&thread);
+  if (NS_FAILED(rv)) {
+    NS_WARNING("Droping timer event because thread is dead");
+    return;
+  }

  nsCOMPtr<nsIEventQueue> queue;
  if (gThread)