corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1966754 - reduce SVGFE render task resolution for excessively large inputs r=gfx-reviewers,ErichDonGubler a=diannaS

Browse Source 
Original Revision: https://phabricator.services.mozilla.com/D256388

Differential Revision: https://phabricator.services.mozilla.com/D260363
This commit is contained in:
Ashley Hale
2025-08-07 21:48:07 +00:00
committed by dsmith@mozilla.com
parent 8a33ca95a6
commit 45f01ba16c
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gfx/wr/webrender/src/render_task.rs
View File

@@ -1968,6 +1968,7 @@ impl RenderTask {
// //
// Also look up the child tasks while we are here. // Also look up the child tasks while we are here.
let mut used_subregion = LayoutRect::zero(); let mut used_subregion = LayoutRect::zero();
let mut combined_input_subregion = LayoutRect::zero();
let node_inputs: Vec<(FilterGraphPictureReference, RenderTaskId)> = node.inputs.iter().map(|input| { let node_inputs: Vec<(FilterGraphPictureReference, RenderTaskId)> = node.inputs.iter().map(|input| {
let (subregion, task) = let (subregion, task) =
match input.buffer_id { match input.buffer_id {
@@ -2005,6 +2006,7 @@ impl RenderTask {
), ),
); );
used_subregion = used_subregion.union(&target_subregion); used_subregion = used_subregion.union(&target_subregion);
combined_input_subregion = combined_input_subregion.union(&subregion);
(FilterGraphPictureReference{ (FilterGraphPictureReference{
buffer_id: input.buffer_id, buffer_id: input.buffer_id,
// Apply offset to the placement of the input subregion. // Apply offset to the placement of the input subregion.
@@ -2218,7 +2220,7 @@ impl RenderTask {
std_deviation_y.ceil() * BLUR_SAMPLE_SCALE) std_deviation_y.ceil() * BLUR_SAMPLE_SCALE)
} }
_ => used_subregion, _ => used_subregion,
}; }.union(&combined_input_subregion);
while while
padded_subregion.scale(device_to_render_scale, device_to_render_scale).round().width() + node_inflate as f32 * 2.0 > MAX_SURFACE_SIZE as f32 || padded_subregion.scale(device_to_render_scale, device_to_render_scale).round().width() + node_inflate as f32 * 2.0 > MAX_SURFACE_SIZE as f32 ||
padded_subregion.scale(device_to_render_scale, device_to_render_scale).round().height() + node_inflate as f32 * 2.0 > MAX_SURFACE_SIZE as f32 { padded_subregion.scale(device_to_render_scale, device_to_render_scale).round().height() + node_inflate as f32 * 2.0 > MAX_SURFACE_SIZE as f32 {

10
testing/web-platform/tests/svg/crashtests/firefox-bug-1966754.html Normal file
View File

@@ -0,0 +1,10 @@
<!doctype html>
<body>
<svg>
<filter id="crash" x="0" y="0" width="400px" height="400px">
<feColorMatrix in="SourceGraphic" values="0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0 0"></feColorMatrix>
<feGaussianBlur stdDeviation="4"></feGaussianBlur>
</filter>
<rect width="100" height="100" filter="url(#crash)"/>
</svg>
</body>