corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1309720, ensure expected DOM tree operations when calling insertBefore, r=ehsan

Browse Source
This commit is contained in:
Olli Pettay
2016-10-14 15:33:42 +03:00
parent 6f19ca1a32
commit 45a7bbd8ea
12 changed files with 33 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
dom/html/HTMLTableElement.cpp
View File

@@ -412,7 +412,8 @@ HTMLTableElement::CreateTHead()
}
ErrorResult rv;
nsINode::InsertBefore(*head, nsINode::GetFirstChild(), rv);
nsCOMPtr<nsINode> refNode = nsINode::GetFirstChild();
nsINode::InsertBefore(*head, refNode, rv);
}
return head.forget();
}
@@ -503,7 +504,7 @@ HTMLTableElement::CreateTBody()
NS_NewHTMLTableSectionElement(nodeInfo.forget());
MOZ_ASSERT(newBody);
nsIContent* referenceNode = nullptr;
nsCOMPtr<nsIContent> referenceNode = nullptr;
for (nsIContent* child = nsINode::GetLastChild();
child;
child = child->GetPreviousSibling()) {
@@ -615,7 +616,8 @@ HTMLTableElement::InsertRow(int32_t aIndex, ErrorResult& aError)
HTMLTableSectionElement* section =
static_cast<HTMLTableSectionElement*>(rowGroup.get());
nsIHTMLCollection* rows = section->Rows();
rowGroup->InsertBefore(*newRow, rows->Item(0), aError);
nsCOMPtr<nsINode> refNode = rows->Item(0);
rowGroup->InsertBefore(*newRow, refNode, aError);
}
}
}