corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

- Trace JSOP_NEWINIT/INITPROP/INITELEM/ENDINIT, which required extending the FastNewObject builtin to create a dense Array or a new Object (easy to discriminate on the constructor function's u.n.clasp member).

Browse Source 
- Fix record_JSOP_SETELEM to avoid storing if a JSOP_POP that will be skipped follows.
This commit is contained in:
Brendan Eich
2008-08-11 10:24:47 -07:00
parent 2cef6e066a
commit 44a191960c
2 changed files with 33 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
js/src/jsbuiltins.cpp
View File

@@ -338,10 +338,16 @@ js_CallTree(InterpState* state, Fragment* f)
return u.func(state, NULL);
}
JS_STATIC_ASSERT(JSSLOT_PRIVATE == JSSLOT_ARRAY_LENGTH);
JS_STATIC_ASSERT(JSSLOT_ARRAY_LENGTH + 1 == JSSLOT_ARRAY_COUNT);
JSObject* FASTCALL
js_FastNewObject(JSContext* cx, JSObject* ctor)
{
JS_ASSERT(HAS_FUNCTION_CLASS(ctor));
JSFunction* fun = GET_FUNCTION_PRIVATE(cx, ctor);
JS_ASSERT(!FUN_INTERPRETED(fun));
JSClass* clasp = fun->u.n.clasp;
JSObject* obj = (JSObject*) js_NewGCThing(cx, GCF_DONT_BLOCK | GCX_OBJECT, sizeof(JSObject));
if (!obj)
@@ -362,8 +368,15 @@ js_FastNewObject(JSContext* cx, JSObject* ctor)
obj->fslots[JSSLOT_PROTO] = OBJECT_TO_JSVAL(proto);
obj->fslots[JSSLOT_PARENT] = ctor->fslots[JSSLOT_PARENT];
obj->fslots[JSSLOT_CLASS] = PRIVATE_TO_JSVAL(&js_ObjectClass);
for (unsigned i = JSSLOT_PRIVATE; i != JS_INITIAL_NSLOTS; ++i)
obj->fslots[JSSLOT_CLASS] = PRIVATE_TO_JSVAL(clasp);
unsigned i = JSSLOT_PRIVATE;
if (clasp == &js_ArrayClass) {
obj->fslots[JSSLOT_ARRAY_LENGTH] = 0;
obj->fslots[JSSLOT_ARRAY_COUNT] = 0;
i += 2;
}
for (; i != JS_INITIAL_NSLOTS; ++i)
obj->fslots[i] = JSVAL_VOID;
obj->map = js_HoldObjectMap(cx, proto->map);