Bug 1956952 - Add a probe for when CPM is enabled in sidebar customization panel. r=rsafaeian,sidebar-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D243389
This commit is contained in:
@@ -687,3 +687,24 @@ contextual_manager:
|
|||||||
opened:
|
opened:
|
||||||
type: boolean
|
type: boolean
|
||||||
description: Whether the sidebar is opening.
|
description: Whether the sidebar is opening.
|
||||||
|
sidebar_customize_enabled:
|
||||||
|
type: event
|
||||||
|
description: >
|
||||||
|
User clicked on the checkbox corresponding to the "Passwords" entry on sidebar customization settings.
|
||||||
|
bugs:
|
||||||
|
- https://bugzilla.mozilla.org/show_bug.cgi?id=1956952
|
||||||
|
data_reviews:
|
||||||
|
- https://bugzilla.mozilla.org/show_bug.cgi?id=1947634
|
||||||
|
data_sensitivity:
|
||||||
|
- interaction
|
||||||
|
expires: never
|
||||||
|
notification_emails:
|
||||||
|
- issozi@mozilla.com
|
||||||
|
- tthorne@mozilla.com
|
||||||
|
- passwords-dev@mozilla.org
|
||||||
|
send_in_pings:
|
||||||
|
- events
|
||||||
|
extra_keys:
|
||||||
|
checked:
|
||||||
|
type: boolean
|
||||||
|
description: Whether the Passwords box was checked.
|
||||||
|
|||||||
@@ -153,6 +153,11 @@ export class SidebarCustomize extends SidebarPage {
|
|||||||
checked: e.target.checked,
|
checked: e.target.checked,
|
||||||
});
|
});
|
||||||
break;
|
break;
|
||||||
|
case "viewCPMSidebar":
|
||||||
|
Glean.contextualManager.sidebarCustomizeEnabled.record({
|
||||||
|
checked: e.target.checked,
|
||||||
|
});
|
||||||
|
break;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -249,10 +249,7 @@ add_task(async function test_review_checker_sidebar_toggle() {
|
|||||||
|
|
||||||
add_task(async function test_contextual_manager_toggle() {
|
add_task(async function test_contextual_manager_toggle() {
|
||||||
await SpecialPowers.pushPrefEnv({
|
await SpecialPowers.pushPrefEnv({
|
||||||
set: [
|
set: [["browser.contextual-password-manager.enabled", true]],
|
||||||
["browser.contextual-password-manager.enabled", true],
|
|
||||||
["sidebar.revamp", false],
|
|
||||||
],
|
|
||||||
});
|
});
|
||||||
await SidebarController.waitUntilStable();
|
await SidebarController.waitUntilStable();
|
||||||
const gleanEvent = Glean.contextualManager.sidebarToggle;
|
const gleanEvent = Glean.contextualManager.sidebarToggle;
|
||||||
@@ -261,6 +258,20 @@ add_task(async function test_contextual_manager_toggle() {
|
|||||||
await SidebarController.waitUntilStable();
|
await SidebarController.waitUntilStable();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
add_task(async function test_customize_contextual_manager_enabled() {
|
||||||
|
await SpecialPowers.pushPrefEnv({
|
||||||
|
set: [["browser.contextual-password-manager.enabled", true]],
|
||||||
|
});
|
||||||
|
await testCustomizeToggle(
|
||||||
|
"viewCPMSidebar",
|
||||||
|
Glean.contextualManager.sidebarCustomizeEnabled,
|
||||||
|
false
|
||||||
|
);
|
||||||
|
await SpecialPowers.popPrefEnv();
|
||||||
|
await SidebarController.waitUntilStable();
|
||||||
|
Services.fog.testResetFOG();
|
||||||
|
});
|
||||||
|
|
||||||
add_task(async function test_customize_panel_toggle() {
|
add_task(async function test_customize_panel_toggle() {
|
||||||
await testSidebarToggle(
|
await testSidebarToggle(
|
||||||
"viewCustomizeSidebar",
|
"viewCustomizeSidebar",
|
||||||
|
|||||||
Reference in New Issue
Block a user