corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1817297 - Stop sending PreferenceUpdate IPC messages for sanitized preferences, r=florian,KrisWright

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D170115
This commit is contained in:
Florian Quèze
2023-03-06 15:21:36 +00:00
parent 3568c52d39
commit 411879f425
3 changed files with 44 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
modules/libpref/Preferences.cpp
View File

@@ -6029,8 +6029,15 @@ struct PrefListEntry {
size_t mLen;
};
// These prefs are not useful in child processes - do not send them
static const PrefListEntry sParentOnlyPrefBranchList[] = {
// A preference is 'sanitized' (i.e. not sent to web content processes) if
// one of two criteria are met:
// 1. The pref name matches one of the prefixes in the following list
// 2. The pref is dynamically named (i.e. not specified in all.js or
// StaticPrefList.yml), a string pref, and it is NOT exempted in
// sDynamicPrefOverrideList
//
// This behavior is codified in ShouldSanitizePreference() below
static const PrefListEntry sRestrictFromWebContentProcesses[] = {
// Remove prefs with user data
PREF_LIST_ENTRY("datareporting.policy."),
PREF_LIST_ENTRY("browser.download.lastDir"),
@@ -6168,7 +6175,7 @@ static bool ShouldSanitizePreference(const Pref* const aPref) {
// The services pref is an annoying one - it's much easier to blocklist
// the whole branch and then add this one check to let this one annoying
// pref through.
for (const auto& entry : sParentOnlyPrefBranchList) {
for (const auto& entry : sRestrictFromWebContentProcesses) {
if (strncmp(entry.mPrefBranch, prefName, entry.mLen) == 0) {
const auto* p = prefName; // This avoids clang-format doing ugly things.
return !(strncmp("services.settings.clock_skew_seconds", p, 36) == 0 ||