corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1301346 - Add telemetry to collect how much time was spent in handling beforeunload and unload event. r=bsmedberg,smaug

Browse Source 
MozReview-Commit-ID: 3jCsBcDncGC
This commit is contained in:
Kan-Ru Chen
2016-09-09 12:06:36 +08:00
parent c996f27601
commit 3ee25b0923
2 changed files with 27 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
layout/base/nsDocumentViewer.cpp
View File

@@ -1141,8 +1141,11 @@ nsDocumentViewer::PermitUnloadInternal(bool *aShouldPrompt,
nsIDocument::PageUnloadingEventTimeStamp timestamp(mDocument); nsIDocument::PageUnloadingEventTimeStamp timestamp(mDocument);
mInPermitUnload = true; mInPermitUnload = true;
EventDispatcher::DispatchDOMEvent(window, nullptr, event, mPresContext, {
nullptr); Telemetry::AutoTimer<Telemetry::HANDLE_BEFOREUNLOAD_MS> telemetryTimer;
EventDispatcher::DispatchDOMEvent(window, nullptr, event, mPresContext,
nullptr);
}
mInPermitUnload = false; mInPermitUnload = false;
} }
@@ -1325,7 +1328,10 @@ nsDocumentViewer::PageHide(bool aIsUnload)
nsIDocument::PageUnloadingEventTimeStamp timestamp(mDocument); nsIDocument::PageUnloadingEventTimeStamp timestamp(mDocument);
EventDispatcher::Dispatch(window, mPresContext, &event, nullptr, &status); {
Telemetry::AutoTimer<Telemetry::HANDLE_UNLOAD_MS> telemetryTimer;
EventDispatcher::Dispatch(window, mPresContext, &event, nullptr, &status);
}
} }
#ifdef MOZ_XUL #ifdef MOZ_XUL

18
toolkit/components/telemetry/Histograms.json
View File

@@ -10374,5 +10374,23 @@
"high": 300000, "high": 300000,
"n_buckets": 30, "n_buckets": 30,
"description": "Time in MS that content is narrated in 10 second increments up to 5 minutes" "description": "Time in MS that content is narrated in 10 second increments up to 5 minutes"
},
"HANDLE_UNLOAD_MS": {
"alert_emails": ["kchen@mozilla.com"],
"expires_in_version": "55",
"kind": "exponential",
"high": 10000,
"n_buckets": 50,
"bug_numbers": [1301346],
"description": "The time spent handling unload event in milliseconds. It measures all documents and subframes separately. If there are multiple handlers for the unload event in a document, this will record a single value across all handlers in the document."
},
"HANDLE_BEFOREUNLOAD_MS": {
"alert_emails": ["kchen@mozilla.com"],
"expires_in_version": "55",
"kind": "exponential",
"high": 10000,
"n_buckets": 50,
"bug_numbers": [1301346],
"description": "The time spent handling beforeunload event in milliseconds. It measures all documents and subframes separately. If there are multiple handlers for the unload event in a document, this will record a single value across all handlers in the document."
} }
} }