corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1850293 - Make editable states not intrinsic. r=smaug,masayuki

Browse Source 
This one is tricky because form controls, though I think I got it right...

This fixes a pre-existing bug where we're not following the spec for readonly
inside content-editable.

I filed this as bug 1850390 but other browsers match the spec so add a test and
fix it while at it. This allows cheaper checks for readonlyness in a couple
places.

Differential Revision: https://phabricator.services.mozilla.com/D186896
This commit is contained in:
Emilio Cobos Álvarez
2023-08-30 09:18:31 +00:00
parent a429e38b7d
commit 3e9e56e2c8
21 changed files with 113 additions and 150 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
dom/html/HTMLTextAreaElement.cpp
View File

@@ -62,12 +62,13 @@ HTMLTextAreaElement::HTMLTextAreaElement(
AddMutationObserver(this);
// Set up our default state. By default we're enabled (since we're
// a control type that can be disabled but not actually disabled
// right now), optional, and valid. We are NOT readwrite by default
// until someone calls UpdateEditableState on us, apparently! Also
// by default we don't have to show validity UI and so forth.
// a control type that can be disabled but not actually disabled right now),
// optional, read-write, and valid. Also by default we don't have to show
// validity UI and so forth.
AddStatesSilently(ElementState::ENABLED | ElementState::OPTIONAL_ |
ElementState::VALID | ElementState::VALUE_EMPTY);
ElementState::READWRITE | ElementState::VALID |
ElementState::VALUE_EMPTY);
RemoveStatesSilently(ElementState::READONLY);
}
HTMLTextAreaElement::~HTMLTextAreaElement() {
@@ -897,6 +898,10 @@ void HTMLTextAreaElement::AfterSetAttr(int32_t aNameSpaceID, nsAtom* aName,
UpdateRequiredState(!!aValue, aNotify);
}
if (aName == nsGkAtoms::readonly && !!aValue != !!aOldValue) {
UpdateReadOnlyState(aNotify);
}
UpdateValueMissingValidityState();
// This *has* to be called *after* validity has changed.
@@ -948,9 +953,7 @@ nsresult HTMLTextAreaElement::CopyInnerTo(Element* aDest) {
return NS_OK;
}
bool HTMLTextAreaElement::IsMutable() const {
return !HasAttr(nsGkAtoms::readonly) && !IsDisabled();
}
bool HTMLTextAreaElement::IsMutable() const { return !IsDisabledOrReadOnly(); }
void HTMLTextAreaElement::SetCustomValidity(const nsAString& aError) {
ConstraintValidation::SetCustomValidity(aError);