Bug 1475228 - Make asynchronous compile APIs take SourceBufferHolders r=jandem

This commit is contained in:
Jon Coppeard
2018-07-17 14:30:23 +01:00
parent e812d24682
commit 3a449ea91d
11 changed files with 49 additions and 48 deletions

View File

@@ -1830,9 +1830,11 @@ ScriptLoader::AttemptAsyncScriptCompile(ScriptLoadRequest* aRequest)
if (aRequest->IsModuleRequest()) {
MOZ_ASSERT(aRequest->IsTextSource());
JS::SourceBufferHolder srcBuf(aRequest->ScriptText().begin(),
aRequest->ScriptText().length(),
JS::SourceBufferHolder::NoOwnership);
if (!JS::CompileOffThreadModule(cx, options,
aRequest->ScriptText().begin(),
aRequest->ScriptText().length(),
srcBuf,
OffThreadScriptLoaderCallback,
static_cast<void*>(runnable))) {
return NS_ERROR_OUT_OF_MEMORY;
@@ -1858,9 +1860,11 @@ ScriptLoader::AttemptAsyncScriptCompile(ScriptLoadRequest* aRequest)
#endif
} else {
MOZ_ASSERT(aRequest->IsTextSource());
JS::SourceBufferHolder srcBuf(aRequest->ScriptText().begin(),
aRequest->ScriptText().length(),
JS::SourceBufferHolder::NoOwnership);
if (!JS::CompileOffThread(cx, options,
aRequest->ScriptText().begin(),
aRequest->ScriptText().length(),
srcBuf,
OffThreadScriptLoaderCallback,
static_cast<void*>(runnable))) {
return NS_ERROR_OUT_OF_MEMORY;