corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1612128 - Add a new label to BFCACHE_COMBO telemetry probe r=smaug

Browse Source 
Add a new label to collect the number of BFCached documents that are not
the only top level documents in their BrowsingContextGroup.

Differential Revision: https://phabricator.services.mozilla.com/D65790
This commit is contained in:
Sean Feng
2020-03-06 22:24:08 +00:00
parent 6b9ff94cfe
commit 39ed83440e
4 changed files with 25 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
docshell/base/nsDocShell.cpp
View File

@@ -6701,6 +6701,19 @@ bool nsDocShell::CanSavePresentation(uint32_t aLoadType,
uint16_t bfCacheCombo = 0;
bool canSavePresentation =
doc->CanSavePresentation(aNewRequest, bfCacheCombo);
MOZ_ASSERT_IF(canSavePresentation, bfCacheCombo == 0);
if (canSavePresentation && doc->IsTopLevelContentDocument()) {
auto* browsingContextGroup = mBrowsingContext->Group();
nsTArray<RefPtr<BrowsingContext>>& topLevelContext =
browsingContextGroup->Toplevels();
for (const auto& browsingContext : topLevelContext) {
if (browsingContext != mBrowsingContext) {
bfCacheCombo |= BFCacheStatus::NOT_ONLY_TOPLEVEL_IN_BCG;
break;
}
}
}
ReportBFCacheComboTelemetry(bfCacheCombo);
return doc && canSavePresentation;
@@ -6712,6 +6725,12 @@ void nsDocShell::ReportBFCacheComboTelemetry(uint16_t aCombo) {
Telemetry::AccumulateCategorical(
Telemetry::LABELS_BFCACHE_COMBO::BFCache_Success);
break;
case SUCCESS_NOT_ONLY_TOPLEVEL:
Telemetry::AccumulateCategorical(
Telemetry::LABELS_BFCACHE_COMBO::BFCache_Success);
Telemetry::AccumulateCategorical(
Telemetry::LABELS_BFCACHE_COMBO::Success_Not_Toplevel);
break;
case UNLOAD:
Telemetry::AccumulateCategorical(Telemetry::LABELS_BFCACHE_COMBO::Unload);
break;