corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1724236 - Move InstantiateStencil call out of JoinOffThread r=arai

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D225361
This commit is contained in:
Bryan Thrall
2024-10-30 13:41:43 +00:00
parent e6436b95c3
commit 38fb4a0034
3 changed files with 25 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
dom/script/ScriptLoader.cpp
View File

@@ -2732,8 +2732,16 @@ void ScriptLoader::InstantiateClassicScriptFromMaybeEncodedSource(
if (aRequest->GetScriptLoadContext()->mCompileOrDecodeTask) {
LOG(("ScriptLoadRequest (%p): Decode Bytecode & instantiate and Execute",
aRequest));
RefPtr<JS::Stencil> stencil;
JS::InstantiationStorage storage;
aExec.JoinOffThread(aCx, aCompileOptions,
aRequest->GetScriptLoadContext(), aScript, aRv);
aRequest->GetScriptLoadContext(), stencil, storage,
aRv);
if (stencil) {
bool unused;
aExec.InstantiateStencil(aCx, aCompileOptions, std::move(stencil),
aScript, unused, aRv, false, &storage);
}
} else {
LOG(("ScriptLoadRequest (%p): Decode Bytecode and Execute", aRequest));
AUTO_PROFILER_MARKER_TEXT("BytecodeDecodeMainThread", JS,
@@ -2766,8 +2774,15 @@ void ScriptLoader::InstantiateClassicScriptFromMaybeEncodedSource(
"Execute",
aRequest));
MOZ_ASSERT(aRequest->IsTextSource());
RefPtr<JS::Stencil> stencil;
JS::InstantiationStorage storage;
aExec.JoinOffThread(aCx, aCompileOptions, aRequest->GetScriptLoadContext(),
aScript, aRv, encodeBytecode);
stencil, storage, aRv);
if (stencil) {
bool unused;
aExec.InstantiateStencil(aCx, aCompileOptions, std::move(stencil),
aScript, unused, aRv, encodeBytecode, &storage);
}
} else {
// Main thread parsing (inline and small scripts)
LOG(("ScriptLoadRequest (%p): Compile And Exec", aRequest));