Bug 1566891 - Remove expired telemetry probes for export options. r=pbro

Differential Revision: https://phabricator.services.mozilla.com/D55073
This commit is contained in:
Razvan Caliman
2019-12-03 11:08:55 +00:00
parent f532e08a47
commit 386e3c12eb
4 changed files with 1 additions and 109 deletions

View File

@@ -23,14 +23,6 @@ loader.lazyRequireGetter(
const ChangesApp = createFactory(require("./components/ChangesApp")); const ChangesApp = createFactory(require("./components/ChangesApp"));
const { getChangesStylesheet } = require("./selectors/changes"); const { getChangesStylesheet } = require("./selectors/changes");
const {
TELEMETRY_SCALAR_CONTEXTMENU_COPY_DECLARATION,
TELEMETRY_SCALAR_CONTEXTMENU_COPY_RULE,
TELEMETRY_SCALAR_COPY_ALL_CHANGES,
TELEMETRY_SCALAR_COPY_RULE,
} = require("./constants");
const { resetChanges, trackChange } = require("./actions/changes"); const { resetChanges, trackChange } = require("./actions/changes");
class ChangesView { class ChangesView {
@@ -153,7 +145,6 @@ class ChangesView {
*/ */
copyAllChanges() { copyAllChanges() {
this.copyChanges(); this.copyChanges();
this.telemetry.scalarAdd(TELEMETRY_SCALAR_COPY_ALL_CHANGES, 1);
} }
/** /**
@@ -203,7 +194,6 @@ class ChangesView {
const isRemoved = element.classList.contains("diff-remove"); const isRemoved = element.classList.contains("diff-remove");
const text = isRemoved ? `/* ${name}: ${value}; */` : `${name}: ${value};`; const text = isRemoved ? `/* ${name}: ${value}; */` : `${name}: ${value};`;
clipboardHelper.copyString(text); clipboardHelper.copyString(text);
this.telemetry.scalarAdd(TELEMETRY_SCALAR_CONTEXTMENU_COPY_DECLARATION, 1);
} }
/** /**
@@ -213,11 +203,8 @@ class ChangesView {
* *
* @param {String} ruleId * @param {String} ruleId
* Rule id of the target CSS rule. * Rule id of the target CSS rule.
* @param {Boolean} usingContextMenu
* True if the handler is invoked from the context menu.
* (Default) False if invoked from the button.
*/ */
async copyRule(ruleId, usingContextMenu = false) { async copyRule(ruleId) {
const inspectorFronts = await this.inspector.getAllInspectorFronts(); const inspectorFronts = await this.inspector.getAllInspectorFronts();
for (const inspectorFront of inspectorFronts) { for (const inspectorFront of inspectorFronts) {
@@ -229,12 +216,6 @@ class ChangesView {
break; break;
} }
} }
if (usingContextMenu) {
this.telemetry.scalarAdd(TELEMETRY_SCALAR_CONTEXTMENU_COPY_RULE, 1);
} else {
this.telemetry.scalarAdd(TELEMETRY_SCALAR_COPY_RULE, 1);
}
} }
/** /**

View File

@@ -1,14 +0,0 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
"use strict";
module.exports = {
TELEMETRY_SCALAR_CONTEXTMENU_COPY_DECLARATION:
"devtools.changesview.contextmenu_copy_declaration",
TELEMETRY_SCALAR_CONTEXTMENU_COPY_RULE:
"devtools.changesview.contextmenu_copy_rule",
TELEMETRY_SCALAR_COPY_ALL_CHANGES: "devtools.changesview.copy_all_changes",
TELEMETRY_SCALAR_COPY_RULE: "devtools.changesview.copy_rule",
};

View File

@@ -15,7 +15,6 @@ DIRS += [
DevToolsModules( DevToolsModules(
'ChangesContextMenu.js', 'ChangesContextMenu.js',
'ChangesView.js', 'ChangesView.js',
'constants.js',
) )
BROWSER_CHROME_MANIFESTS += ['test/browser.ini'] BROWSER_CHROME_MANIFESTS += ['test/browser.ini']

View File

@@ -2343,80 +2343,6 @@ devtools.changesview:
record_in_processes: record_in_processes:
- 'main' - 'main'
copy_all_changes:
bug_numbers:
- 1532583
description: >
Number of times the Copy All Changes button is used in the Changes panel.
expires: "73"
kind: uint
notification_emails:
- dev-developer-tools@lists.mozilla.org
- mbalfanz@mozilla.com
release_channel_collection: opt-out
products:
- 'firefox'
- 'fennec'
- 'geckoview'
record_in_processes:
- 'main'
copy_rule:
bug_numbers:
- 1532583
description: >
Number of times the Copy Rule button is used in the Changes panel.
expires: "73"
kind: uint
notification_emails:
- dev-developer-tools@lists.mozilla.org
- mbalfanz@mozilla.com
release_channel_collection: opt-out
products:
- 'firefox'
- 'fennec'
- 'geckoview'
record_in_processes:
- 'main'
contextmenu_copy_declaration:
bug_numbers:
- 1532583
description: >
Number of times the Copy Declaration option is picked from the Changes panel
context menu.
expires: "73"
kind: uint
notification_emails:
- dev-developer-tools@lists.mozilla.org
- mbalfanz@mozilla.com
release_channel_collection: opt-out
products:
- 'firefox'
- 'fennec'
- 'geckoview'
record_in_processes:
- 'main'
contextmenu_copy_rule:
bug_numbers:
- 1532583
description: >
Number of times the Copy Rule option is picked from the Changes panel
context menu.
expires: "73"
kind: uint
notification_emails:
- dev-developer-tools@lists.mozilla.org
- mbalfanz@mozilla.com
release_channel_collection: opt-out
products:
- 'firefox'
- 'fennec'
- 'geckoview'
record_in_processes:
- 'main'
dom.event: dom.event:
confluence_load_count: confluence_load_count:
bug_numbers: bug_numbers: