corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1771806 - Record last interactive value in TextControlState. r=masayuki

Browse Source 
One unfortunate-ish thing of storing it in TextControlState is that we
can't preserve it across type changes, but that seems ok for now
according to my conversations with Serg.

In the future we might want to move the value to HTMLInputElement itself
or something, we'll see, but this should help folks fix some
long-standing quality issues in the password manager / autofill
implementation.

Differential Revision: https://phabricator.services.mozilla.com/D150148
This commit is contained in:
Emilio Cobos Álvarez
2022-06-28 08:49:12 +00:00
parent 022fc119e7
commit 35e57869d6
7 changed files with 204 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
dom/html/TextControlState.cpp
View File

@@ -1083,7 +1083,13 @@ void TextInputListener::HandleValueChanged() {
}
if (!mSettingValue) {
// NOTE(emilio): execCommand might get here even though it might not be a
// "proper" user-interactive change. Might be worth reconsidering which
// ValueChangeKind are we passing down.
mTxtCtrlElement->OnValueChanged(ValueChangeKind::UserInteraction);
if (mTextControlState) {
mTextControlState->ClearLastInteractiveValue();
}
}
}
@@ -2643,6 +2649,27 @@ bool TextControlState::SetValue(const nsAString& aValue,
return false;
}
const auto changeKind = [&] {
if (aOptions.contains(ValueSetterOption::ByInternalAPI)) {
return ValueChangeKind::Internal;
}
if (aOptions.contains(ValueSetterOption::BySetUserInputAPI)) {
return ValueChangeKind::UserInteraction;
}
return ValueChangeKind::Script;
}();
if (changeKind == ValueChangeKind::Script) {
// This value change will not be interactive. If we're an input that was
// interactively edited, save the last interactive value now before it goes
// away.
if (auto* input = HTMLInputElement::FromNode(mTextCtrlElement)) {
if (input->LastValueChangeWasInteractive()) {
GetValue(mLastInteractiveValue, /* aIgnoreWrap = */ true);
}
}
}
// Note that if this may be called during reframe of the editor. In such
// case, we shouldn't commit composition. Therefore, when this is called
// for internal processing, we shouldn't commit the composition.
@@ -2723,11 +2750,6 @@ bool TextControlState::SetValue(const nsAString& aValue,
// If we were handling SetValue() before, don't update the DOM state twice,
// just let the outer call do so.
if (!wasHandlingSetValue) {
// TODO(emilio): It seems wrong to pass ValueChangeKind::Script if
// BySetUserInput is in aOptions.
auto changeKind = aOptions.contains(ValueSetterOption::ByInternalAPI)
? ValueChangeKind::Internal
: ValueChangeKind::Script;
handlingSetValue.GetTextControlElement()->OnValueChanged(changeKind);
}
return true;
@@ -2992,6 +3014,8 @@ bool TextControlState::SetValueWithoutTextEditor(
aHandlingSetValue.GetTextControlElement()->OnValueChanged(
ValueChangeKind::UserInteraction);
ClearLastInteractiveValue();
MOZ_ASSERT(!aHandlingSetValue.GetSettingValue().IsVoid());
DebugOnly<nsresult> rvIgnored = nsContentUtils::DispatchInputEvent(
MOZ_KnownLive(aHandlingSetValue.GetTextControlElement()),