corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1452390 - Implement paint-skipping support in WebRender. r=botond

Browse Source 
The majority of this patch is just plumbing. The interesting parts are
in WebRenderLayerManager and APZUpdater/WebRenderScrollData. Unlike
ClientLayerManager, which updates the FrameMetrics on the client side
and sends the modified version over to the compositor, this WR version
just sends the update info over to the compositor, which then applies
the update to the metrics saved in APZUpdater before triggering the
hit-testing tree rebuild.

MozReview-Commit-ID: 4latUMa8RFw
This commit is contained in:
Kartikaya Gupta
2018-05-11 21:18:22 -04:00
parent bdee54b9b6
commit 2e44542cc3
14 changed files with 102 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
gfx/layers/wr/WebRenderLayerManager.cpp
View File

@@ -194,15 +194,9 @@ WebRenderLayerManager::EndEmptyTransaction(EndTransactionFlags aFlags)
// Since we don't do repeat transactions right now, just set the time
mAnimationReadyTime = TimeStamp::Now();
// With the WebRenderLayerManager we reject attempts to set most kind of
// "pending data" for empty transactions. Any place that attempts to update
// transforms or scroll offset, for example, will get failure return values
// back, and will fall back to a full transaction. Therefore the only piece
// of "pending" information we need to send in an empty transaction are the
// APZ focus state and canvases's CompositableOperations.
if (aFlags & EndTransactionFlags::END_NO_COMPOSITE &&
!mWebRenderCommandBuilder.NeedsEmptyTransaction()) {
!mWebRenderCommandBuilder.NeedsEmptyTransaction() &&
mPendingScrollUpdates.empty()) {
MOZ_ASSERT(!mTarget);
WrBridge()->SendSetFocusTarget(mFocusTarget);
return true;
@@ -225,7 +219,9 @@ WebRenderLayerManager::EndEmptyTransaction(EndTransactionFlags aFlags)
}
}
WrBridge()->EndEmptyTransaction(mFocusTarget, mLatestTransactionId, transactionStart);
WrBridge()->EndEmptyTransaction(mFocusTarget, mPendingScrollUpdates,
mPaintSequenceNumber, mLatestTransactionId, transactionStart);
ClearPendingScrollInfoUpdate();
MakeSnapshotIfRequired(size);
return true;
@@ -293,6 +289,10 @@ WebRenderLayerManager::EndTransactionWithoutLayer(nsDisplayList* aDisplayList,
}
mScrollData.SetPaintSequenceNumber(mPaintSequenceNumber);
}
// Since we're sending a full mScrollData that will include the new scroll
// offsets, and we can throw away the pending scroll updates we had kept for
// an empty transaction.
ClearPendingScrollInfoUpdate();
mLatestTransactionId = mTransactionIdAllocator->GetTransactionId(/*aThrottle*/ true);
TimeStamp transactionStart = mTransactionIdAllocator->GetTransactionStart();
@@ -628,15 +628,6 @@ WebRenderLayerManager::SetRoot(Layer* aLayer)
MOZ_ASSERT(false);
}
bool
WebRenderLayerManager::SetPendingScrollUpdateForNextTransaction(FrameMetrics::ViewID aScrollId,
const ScrollUpdateInfo& aUpdateInfo)
{
// If we ever support changing the scroll position in an "empty transactions"
// properly in WR we can fill this in. Covered by bug 1382259.
return false;
}
already_AddRefed<PersistentBufferProvider>
WebRenderLayerManager::CreatePersistentBufferProvider(const gfx::IntSize& aSize,
gfx::SurfaceFormat aFormat)